Warnings on HA version 2022.2

[HepoH3]

After updating core following warnings are shown:

Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 89: self._child.sendline(f"connect")

Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 93: self._child.sendline("char-write-cmd 0x000c 0100")

Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 60: self._child.sendline(data)

Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 102: self._child.sendline(f"disconnect")

Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 120: self._child.terminate(force=True)

[ClusterM]

Already fixed, check latest commit.

[HepoH3]

Already fixed, check latest commit.

Got you. I'll switch to master branch.

[HepoH3]

Eh, it still reportiong warnings:

Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 89: self._child.sendline(f"connect")

Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 102: self._child.sendline(f"disconnect")

Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/init.py, line 40: async_dispatcher_send(hass, DISPATCHER_UPDATE)

Detected blocking call inside the event loop. This is causing stability issues. Please report issue for dhcp doing blocking calls at homeassistant/components/dhcp/init.py, line 233: self._discover_hosts = DiscoverHosts()

[ClusterM]

There is no such line in the kettle_connection.py now:

skykettle-ha/custom_components/skykettle/kettle_connection.py

Line 89 in e4e96b5

clean = bytes(r[3:-1])

I just released version 1.1, try it.

[HepoH3]

There is no such line in the kettle_connection.py now:

skykettle-ha/custom_components/skykettle/kettle_connection.py

Line 89 in e4e96b5

clean = bytes(r[3:-1])

I just released version 1.1, try it.

Now it's better, but last warning remains:

Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 73: self._child.sendline(data)

[ClusterM]

Hm. I'll check it.

[ClusterM]

Sorry, I'm an idiot. Seems like I really fixed it now.

[HepoH3]

It seems like it, thank you!
Don't be so hard on yourself your integration is great!

[HepoH3]

Sorry to bother you, but it's not over 😅

Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/init.py, line 43: await hass.async_add_executor_job(schedule_poll)

[ClusterM]

Please try commit 5ce7163

[HepoH3]

Found another one:

Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 133: self._child.terminate(force=True)

[HepoH3]

I think we need separate brunch for blocking calls which eventually will be merged into master with squashed commits.

[HepoH3]

2022-02-11 10:36:46 WARNING (MainThread) [homeassistant.util.async_] Detected blocking call inside the event loop. This is causing stability issues. Please report issue to the custom component author for skykettle doing blocking calls at custom_components/skykettle/init.py, line 43: hass.async_add_executor_job(schedule_poll, timedelta(seconds=entry.data[CONF_SCAN_INTERVAL]))

[ClusterM]

Please try the version 1.2. I also updated my server to 2022.2 and tested it for a while.

[HepoH3]

Please try the version 1.2. I also updated my server to 2022.2 and tested it for a while.

There is no wanings at first. But after the night following apeared:

skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 99: self._child = pexpect.spawn("gatttool", ['-I', '-t', 'random', '-b', self._mac], timeout=KettleConnection.BLE_TIMEOUT)

skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 56: await self.hass.async_add_executor_job(self._child.sendline, data)

Also I noticed that I need to disconnect/reconnect my bluetooth dongle about few times a day. I'll try to switch back to earlier versions. If I remember correct, in past there was no such problem (I needed to reconnect dongl but no so frequent).

[HepoH3]

After few days and core updates I can say that there is far more less warnings for now. But I have repeated times error with following message:

Can't terminate, error (TypeError): async_add_executor_job() got an unexpected keyword argument 'force'
Source: custom_components/skykettle/kettle_connection.py:140

[ClusterM]

After few days and core updates I can say that there is far more less warnings for now. But I have repeated times error with following message:

Can't terminate, error (TypeError): async_add_executor_job() got an unexpected keyword argument 'force'
Source: custom_components/skykettle/kettle_connection.py:140

Fixed in the latest commit, thank you.

[HepoH3]

It's started again:

Detected blocking call to sleep inside the event loop. This is causing stability issues. Please report issue to the custom integration author for skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 116: if self._child and self._child.isalive():
Detected blocking call to sleep inside the event loop. This is causing stability issues. Please report issue to the custom integration author for skykettle doing blocking calls at custom_components/skykettle/kettle_connection.py, line 64: await self.hass.async_add_executor_job(self._child.sendcontrol, data)

Maybe it's kinda connected to new bluetooth integration from HA 2022.08, dunno.

For now I can see bluetooth goes unavailable after some time.

[ClusterM]

doing blocking calls at custom_components/skykettle/kettle_connection.py, line 64: await self.hass.async_add_executor_job(self._child.sendcontrol, data)

But it's async call, it can't block by design...

[HepoH3]

I think that thing with blocking calls sometimes have a false alarms, or we don't understand something.

[ClusterM]

Version from master uses totally new Bluetooth API, so those methods are removed anyway.