-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Cycle.js linting #17
Comments
I pushed my initial commit and fixed the code linting problems in your example project already you can see the current state here: https://github.com/kahlil/cycle-browserify-boilerplate |
OK I think I have a good base right now: https://github.com/kahlil/cycle-browserify-boilerplate I use zuul for testing though and I am not hmr yet. It seems like the browserify-hmr implementation is still quite buggy and there is not a lot of progress there. |
Hi @kahlil not sure what is happening these never showed up on my feed so totally missed them but thanks again for doing your version, I'll update my linting tools to reflects yours too 😄 |
Oh that's weird @Cmdv. No problem I was happy to do it. Yeah I am really happy with the xo linting :). Cheers! |
@Cmdv not sure if you saw the latest state of the linting. I also added the Immutable plugin for eslint. It works really well with atom-linter-xo now as well due to a bug fix in eslint. Make sure you also don't miss the xo config in the package.json: https://github.com/kahlil/cycle-browserify-boilerplate/blob/master/package.json#L25-L52 |
sweet thanks @kahlil I'll make the amends this evening 👍 also know why I missed this issue, I wasn't actually watching the repo!!! haha oops |
While finishing up the browserify boilerplate I am adding the Cycle.js specific linting.
If you want you can add it as well by just doing
npm i eslint-config-cycle babel-eslint
, adding a.eslintrc
, with:And now you can lint your code Cycle-style!
The text was updated successfully, but these errors were encountered: