Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Cycle.js linting #17

Open
kahlil opened this issue Feb 16, 2016 · 7 comments
Open

Introduce Cycle.js linting #17

kahlil opened this issue Feb 16, 2016 · 7 comments

Comments

@kahlil
Copy link

kahlil commented Feb 16, 2016

While finishing up the browserify boilerplate I am adding the Cycle.js specific linting.

If you want you can add it as well by just doing npm i eslint-config-cycle babel-eslint, adding a .eslintrc, with:

{
  "extends": "eslint-config-cycle",
  "parser": "babel-eslint"
}

And now you can lint your code Cycle-style!

@kahlil
Copy link
Author

kahlil commented Feb 16, 2016

I pushed my initial commit and fixed the code linting problems in your example project already you can see the current state here: https://github.com/kahlil/cycle-browserify-boilerplate

@kahlil
Copy link
Author

kahlil commented Mar 2, 2016

OK I think I have a good base right now: https://github.com/kahlil/cycle-browserify-boilerplate

I use zuul for testing though and I am not hmr yet. It seems like the browserify-hmr implementation is still quite buggy and there is not a lot of progress there.

@Cmdv
Copy link
Owner

Cmdv commented Mar 28, 2016

Hi @kahlil not sure what is happening these never showed up on my feed so totally missed them but thanks again for doing your version, I'll update my linting tools to reflects yours too 😄

@kahlil
Copy link
Author

kahlil commented Mar 28, 2016

Oh that's weird @Cmdv. No problem I was happy to do it. Yeah I am really happy with the xo linting :). Cheers!

@kahlil
Copy link
Author

kahlil commented Mar 29, 2016

@Cmdv not sure if you saw the latest state of the linting. I also added the Immutable plugin for eslint. It works really well with atom-linter-xo now as well due to a bug fix in eslint. Make sure you also don't miss the xo config in the package.json:

https://github.com/kahlil/cycle-browserify-boilerplate/blob/master/package.json#L25-L52

@Cmdv
Copy link
Owner

Cmdv commented Mar 29, 2016

sweet thanks @kahlil I'll make the amends this evening 👍

also know why I missed this issue, I wasn't actually watching the repo!!! haha oops

@kahlil
Copy link
Author

kahlil commented Mar 29, 2016

👍

hahaha oooops!

gif-keyboard-7499486133460680767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants