Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP_CentralStation not working properly with RemoteTech #31

Open
ZeroA4 opened this issue May 31, 2017 · 7 comments
Open

SEP_CentralStation not working properly with RemoteTech #31

ZeroA4 opened this issue May 31, 2017 · 7 comments

Comments

@ZeroA4
Copy link

ZeroA4 commented May 31, 2017

The Central Station antenna does not work with Remote Tech as of SEP v2.1.4 and RemoteTech v1.8.6 in KSP 1.2.2

The antenna is simply ignored by Remote Tech. But the Central Station works as a RT probe if you stick an external antenna to it.
But instead of just complaining. I decide to try my hand at the Remote Tech MM patch.
https://remotetechnologiesgroup.github.io/RemoteTech/modders/modules/ says:

"You must remove any ModuleDataTransmitter modules from the antenna if using ModuleRTAntenna."

So:


	!MODULE[ModuleDataTransmitter]
	{
	}

Great ! the antenna now works! But We lose the animation... Humm Workable but... I want the animation...
It has to have something to do with ModuleAnimateGeneric

The patch already has a reference to ModuleAnimateGeneric but the original .cfgt file does not. The animation is referred inside ModuleSEPStation

Comparing to the RT patch to the Stock antenna:
The stock antenna has its animation referred inside ModuleDeployableAntenna
The RT patch has:

	@MODULE[ModuleDeployableAntenna]
	{
		%name=ModuleAnimateGeneric
		%allowManualControl = false
		%actionAvailable = false
		%eventAvailableFlight = false
		%eventAvailableEditor = false
		%eventAvailableEVA = false
	}

So lets add:

	@MODULE[ModuleSEPStation]
	{
		%name=ModuleAnimateGeneric
		%allowManualControl = false
		%actionAvailable = false
		%eventAvailableFlight = false
		%eventAvailableEditor = false
		%eventAvailableEVA = false
	}

Bingo! Working antenna and working animation!

My_SEP_RemoteTech.cfg.txt

PS: Just Saw the SEP 2.1.5... but its RT patch looks the same.

@ZeroA4 ZeroA4 changed the title SEP_CentralStation not working propelly with RemoteTech SEP_CentralStation not working properly with RemoteTech May 31, 2017
@ZeroA4
Copy link
Author

ZeroA4 commented May 31, 2017

Err... Working antenna, working animation but... useless Central Station. Not good Zero!

"@module" with "%name=" replaces the module name. Resulting in a SEP_CentralStation without a ModuleSEPStation.

We should use a "%MODULE" to add the ModuleAnimateGeneric. but them we need to refer to the animation name or we lose animation again.

This should work:


	%MODULE[ModuleAnimateGeneric] {
		%animationName = ExtendAntenna
		%allowManualControl = false
	}
	
	!MODULE[ModuleDataTransmitter]{
	}
	
	%MODULE[ModuleRTAntenna] {
		%Mode0OmniRange = 0
		%Mode1OmniRange = 2500000
		%MaxQ = 6000
		%EnergyCost = 0.13

		%DeployFxModules = 0
		%animationName = ExtendAntenna
		
		%TRANSMITTER {
			%PacketInterval = 0.3
			%PacketSize = 2
			%PacketResourceCost = 15.0
		}

My_new_SEP_RemoteTech.cfg.txt

@DMagic1
Copy link
Collaborator

DMagic1 commented May 31, 2017

It's that DeployFxModules line that tells the RT antenna (and a standard antenna) which part module is used to play the animation. That module is usually ModuleAnimateGeneric but it doesn't have to be.

In this case the DeployFxModules line should be 1, not 0, since the SEP Central Station module is the 2nd in the list (after the KIS Item module).

The existing RT MM patch is wrong in many ways (that might be the source of some of the other RT issues that have been reported), I just haven't looked at it until now.

I'll see about fixing that now for people who want to stick with KSP 1.2. And I'll get to updating this for 1.3 probably tomorrow (there shouldn't be much changed).

@DMagic1
Copy link
Collaborator

DMagic1 commented May 31, 2017

@ZeroA4 Can you try out this version of the MM patch:
https://github.com/CobaltWolf/Surface-Experiment-Pack/blob/c40200cfa7f13661530344fd972c8ce9014c740f/GameData/SurfaceExperimentPackage/SEP_RemoteTech.cfg

               @PART[SEP_CentralStation]:NEEDS[RemoteTech]
                {
                   %MODULE[ModuleSPU] {
                   }

                   !MODULE[ModuleDataTransmitter]{
                   }

                   %MODULE[ModuleRTAntenna] {
                	 %Mode0OmniRange = 0
	                 %Mode1OmniRange = 2500000
	                 %MaxQ = 6000
	                 %EnergyCost = 0.13
	
	                 %DeployFxModules = 1
	
	                 %TRANSMITTER {
		                    %PacketInterval = 0.3
		                    %PacketSize = 2
		                    %PacketResourceCost = 15.0
	                 }
                     }
                  }

@thomas15v
Copy link

image
image
The antenna works now, but there is no way to transmit the science with that connection.

@DMagic1
Copy link
Collaborator

DMagic1 commented Jul 2, 2017

Do you mean transmission doesn't work, or that there is not button for transmitting/reviewing the science? Only an EVA Kerbal can review, collect, or transmit the science.

If the Central Station upgrade is unlocked from the tech tree then you can set it to automatically transmit science, I think that can be toggle from the UI window, as well as by an EVA Kerbal.

@ghost
Copy link

ghost commented Aug 1, 2017

@DMagic1

Only an EVA Kerbal can review, collect, or transmit the science.

Why is that? I thought the point of the mod was to land somewhere using Kerbals, set up the experiments, and leave; then when they are done transmit the science back.

I am having the same problem that @thomas15v is having, I set up a station on the Mun and now can't transmit anything.

@grafvonzan
Copy link

I can confirm that there is an issue with this. Despite having the Central Station upgrade, I am unable to have science automatically transmitted back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants