Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting bestfit likelihood and chi-square #167

Open
misharash opened this issue Apr 23, 2021 · 3 comments
Open

Getting bestfit likelihood and chi-square #167

misharash opened this issue Apr 23, 2021 · 3 comments

Comments

@misharash
Copy link
Contributor

Currently, if I run minimizer with ignore_prior=True, -log(Like) and chi-sq at the top of {prefix}.bestfit still represent the posterior. If there are different groups of likelihood, their total log-likelihood (without prior) and corresponding chi2 are not presented in the file.
Not really an issue, since the total likelihood chi2 is available in {prefix}.bestfit.txt. Though that file is not very human-readable, so writing this info in {prefix}.bestfit too may be a convenient enhancement.

@juan-s-cruz
Copy link

I get the totals printed on both files as it is intended, have you tried isolating the issue?

@misharash
Copy link
Contributor Author

Here is a super simple example config. With the current version of the code, it gives such gaussian.bestfit file. If we ignore prior, both log-likelihood and chi2 would be 0, but the info at the top is different, clearly including prior. We can see chi2 from each likelihood (without prior) separately, but sum of the two is not present. Total chi2=0 is only present in gaussian.bestfit.txt.

@misharash
Copy link
Contributor Author

This is similar to #247, I'm just trying to argue that with ignore_prior=True it could be reasonable to output the exact thing that was minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants