Better ViaVersion Patch

[crafter23456]

Video example: https://drive.google.com/file/d/1ChiCEbdalCEL1ZK2Yvb_13lqdVWrUbKA/view?usp=sharing

Viaversion discord said it could be made better
idk but yeah it fixes if I stand at one place that I cant place blocks in me, but when I move I can still place blocks in me 😄
With the paper in the name the bug is 100% there like without the via patch, when I rename it to a random name, when lucas patch gets triggered it works like in the video, not 100% good.
& an option to disable the anticrash would be cool :P

[ghost]

The ViaVersion fix ins't NachoSpigot issue, Lucas only ported it for people that doesn't use Paper or Taco in the server brand.

And yes, i would like the option to enable/disable the anticrash system

[Sculas]

I'm perfectly fine with removing the faulty patch from Paper as long as it doesn't cause issues.
And yes, I will add that.

[ghost]

I'm perfectly fine with removing the faulty patch from Paper as long as it doesn't cause issues.
And yes, I will add that.

If you remove the faulty patch of paper, then you're breaking tons of things now

[Sculas]

Oh, that's lovely. Removing a broken patch that breaks other things.
I love programming.

[crafter23456]

With Paper in the brand the block-placement was completely buggy
With something other than Paper in the brand the block-placement is better but still like in the video
The viaversion discord said the patch could be made better that viaversion do it and not that patch. But I'm not a dev so I cant rate it.
I could do some further testing cause they were a month old.
What you said to crafter23456@1e46d75 not all but something like netty dependency updating 😄but like as above you can better estimate it.

[Sculas]

Yeah, I need to update Netty, forgot to do that. Hope it doesn't cause issues hehe

[crafter23456]

Okay, I tested it, doesnt matter if I use Paper or a random name in the mod. But still same szenario like in the video.

[crafter23456]

So the anticrash option please & what with the viaversion thing? I mean I personally dont know what the viaversion discord mean with use via to patch it and dont make an own patch or like that.

I'm perfectly fine with removing the faulty patch from Paper as long as it doesn't cause issues.
And yes, I will add that.

[Sculas]

Fixed in #72

[crafter23456]

Still the via problem
The class bukkit.listeners.protocol1_9to1_8.PaperPatch doesnt exists since the 14 april 2021 ViaVersion/ViaVersion@61e4764#diff-91357865906f00ef2b65e9fc58962908f0f45f7b9a61bb73077d771693f3ca34
Class<?> paperPatchClass = Class.forName(viaVersionPackage + "bukkit.listeners.protocol1_9to1_8.PaperPatch", true, cl);
What I think they changed is that the taco, paper and torch thing got removed that it get added to all versions below 1.9.
The weird thing is that when I rename it to "paper" its completely broken like before, when I call it Paper or like that its like in the video I sent in the first comment