Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Suggestion: Remove all "running test $TEST" statements #13

Closed
JosephFKnight opened this issue May 26, 2019 · 3 comments
Closed

Suggestion: Remove all "running test $TEST" statements #13

JosephFKnight opened this issue May 26, 2019 · 3 comments
Projects

Comments

@JosephFKnight
Copy link
Collaborator

the discord.py library gives us sane rate handling, blessed be to Danny. So this means that if a bot is spamming the library holds onto its messages so it doesn't get denied by discord. Therefore every message we send that isn't a test during a --run all reduces test throughput.

the "running test.." messages cut our test throughput in half, doubling the amount of time it takes to run a full suite.

I propose we hotfix this in, it would take the removal of only a couple lines.

@JosephFKnight
Copy link
Collaborator Author

I opened a pr #14 that pushes this to master branch. But you can just use that as a blueprint and remove those four lines in whatever branch you think is appropriate.

@Cobular Cobular added this to To do in To-Do via automation May 27, 2019
@Cobular Cobular added the test label May 27, 2019
@Cobular
Copy link
Owner

Cobular commented May 27, 2019

That sounds great, I hadn't thought of that. I'll take a look!

@JosephFKnight
Copy link
Collaborator Author

I'm gonna just go ahead integrate this change in feature/refactor_modules and it will get added in when we push to master, as I imagine we aren't far from the next release.

To-Do automation moved this from To do to Done May 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
To-Do
  
Done
Development

No branches or pull requests

2 participants