Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle crashing when parsing #3768

Closed
S1NE4T3R opened this issue Jun 29, 2019 · 24 comments
Closed

Oracle crashing when parsing #3768

S1NE4T3R opened this issue Jun 29, 2019 · 24 comments
Labels
App - Oracle Tickets relating to the oracle application Defect - Crash OS - Windows Issue specific to windows operating systems

Comments

@S1NE4T3R
Copy link

System Information:
Win 7 SP1 32bit


Tried to update Oracle yesterday to check if M20 was out (last time I updated was when MH1 came out and that worked fine) and Oracle just crashed while parsing the .json file it downloads. Every single time after that it just crashes and can't update. I updated Cockatrice, same result. Fresh installed Cockatrice, same. Tried dling the .json file manually and do the local file update, same. I'm using the correct version of Cockatrice for my OS, all the files are trusted on my antivirus (even with it off, crashes all the same), firewall has exception for Cockatrice, I don't know what's up, especially since it was working perfectly fine not that long ago, and since I did a fresh install, now I have no card database on it and can't use it. Help?

error1
error2

@tooomm
Copy link
Member

tooomm commented Jun 30, 2019

Please provide complete information about your system and Cockatrice from the debug window as asked for.

Go to Help → View Debug Log and copy everything above the separation line here!

If you can't install Cockatrice to access that information, make
sure to include your OS and the app version from the setup file here

For example:

Client Version: 2.6.0 (2018-06-17)
Client Operating System: Windows 10 (10.0)
Build Architecture: 64-bit
Qt Version: 5.9.5
System Locale: en_US

In your case, you can also check the version that Oracle displays on the first screen when you run it.

@S1NE4T3R
Copy link
Author

Client Version: 2.7.2-beta (2019-06-12)
Client Operating System: Windows 7 SP 1 (6.1)
Build Architecture: 32-bit
Qt Version: 5.12.2
System Locale: pt_PT
Install Mode: Standard

Oracle displays "2.7.2-beta (2019-06-12)" as well.

@ctrlaltca
Copy link
Contributor

Thank you for the report, I can confirm the bug and it seems to happen only on windows, on 32bit builds.

@tooomm
Copy link
Member

tooomm commented Jul 2, 2019

@S1NE4T3R can you maybe try the 64Bit install for now? It’s very very unlikely that you have to use the old 32bit version...

Wondering why nobody else complained yet. There are at least some people still downloading 32bit 🙈

@ebbit1q
Copy link
Member

ebbit1q commented Jul 3, 2019

There are people running cockatrice on older hardware that is not compatible with 64-bit. Removing support would mean they can't use cockatrice anymore.

@tooomm
Copy link
Member

tooomm commented Jul 3, 2019

older hardware that is not compatible with 64-bit

I think the hardware is probably less of an issue. But the operating systems could be a problem for some (Windows 7 installations in 32bit in particular).

@ebbit1q
Copy link
Member

ebbit1q commented Jul 3, 2019

If you installed a 32-bit os on a 64-bit system, don't.

@S1NE4T3R
Copy link
Author

S1NE4T3R commented Jul 3, 2019

@S1NE4T3R can you maybe try the 64Bit install for now? It’s very very unlikely that you have to use the old 32bit version...

You mean try the 64bit version of Cockatrice? My system is all 32bit, it is older hardware, so I don't think that'll work. Even if I could put a 64bit version of the OS on this puppy, going through the lengthy, tedious installation and backups/updates process on my machine just for a CCG app to work seems like a massive overkill.

I've heard of other people having the same crashing Oracle bug before on reddit, I just never really had it happen to me, for some reason the 32bit version of the app always worked pristine for me till now. Glad to know it's an acknowledged bug though.

@ZeldaZach
Copy link
Member

I can look into smaller MTGJSON builds for legacy Cockatrice support... might be necessary

@DoomOfFools
Copy link

Hello to everyone.
I'm here for a friend of mine. He has the same exact problem of S1NE4T3R. He has a 32-bit system on Windows7

Client Version: 2.7.2-beta (2019-06-12)
Client Operating System: Windows 7 SP 1 (6.1)
Build Architecture: 32-bit
Qt Version: 5.12.2
System Locale: it
System Locale: standard

He has this problem since Modern Horizon. I try to give to him my database, my pictures and my token, but still crash and no new cards are found.
How may I help him?

@tooomm tooomm added App - Oracle Tickets relating to the oracle application Defect - Crash OS - Windows Issue specific to windows operating systems labels Jul 6, 2019
@tooomm
Copy link
Member

tooomm commented Jul 6, 2019

To summarize the problem as it was only said on gitter:
The issue is that our data source for cards, MTGJSON, grew in size over a limit the 32bit version can process.

We are aware and try to look into a solution.

@ebbit1q
Copy link
Member

ebbit1q commented Jul 7, 2019

There is a workaround though, you should be able to get the cards.xml file from another user and replace your own with it.

@S1NE4T3R
Copy link
Author

S1NE4T3R commented Jul 7, 2019

Don't really know anyone personally that uses Cockatrice, I mostly like to build decks on it every once in a while or use it as a catalog tool for the ones I build irl. So I'll still wait for a proper fix. The thought of nagging someone random for a cards.xml file everytime the database is updated doesn't sit well with me. Unless that xml file becomes available as an official download somewhere (assuming it works).

@ZeldaZach
Copy link
Member

For the time being, here you go.
cards.xml.txt

@DoomOfFools
Copy link

Ok, but how can I use it? I have to put in the settings ---> paths ---> cards database ... ?

@ebbit1q
Copy link
Member

ebbit1q commented Jul 8, 2019

just replace the file at the location in the cards database field.

@tooomm
Copy link
Member

tooomm commented Jul 8, 2019

That should work. Yes

But at best you don’t mess with the directory given there and simply put the file Zach linked in that directory.
Of course you have to rename the file to .xml and remove the .txt
In case you don‘t see the TXT file extension your Windows settings are hiding them. Check your explorer options.

@DoomOfFools
Copy link

I tryed in any way. Cockatrice doesn't like this way even I change the extension and made all the correct passage.

Can someone upload a version without .txt?

@ebbit1q
Copy link
Member

ebbit1q commented Jul 9, 2019

The extension does not change the file contents, you should simply name it cards.xml and place it in the correct location.

@DoomOfFools
Copy link

Yeah, ok, done, but the cockatrice app can't load the database anyway. In two hours I will show a screenshot about it

@ebbit1q
Copy link
Member

ebbit1q commented Jul 12, 2019

You can get your logfile through help>view debug log, there you'll find this useful message:

[CockatriceXml4Parser] Trying to parse:  "C:/Program Files (x86)/Cockatrice/cards.xml.txt"
[CockatriceXml4Parser] Parsing failed: wrong extension

rename this file to cards.xml instead

@tooomm
Copy link
Member

tooomm commented Aug 22, 2019

MTGJSON changed to minified JSON as standard and the file should be a bit smaller... but I barely belive that's enough. mtgjson/mtgjson-website#264 (comment)
Can you guys retry again? Does Oracle still crash on 32bit for you? @S1NE4T3R @DoomOfFools

@S1NE4T3R
Copy link
Author

S1NE4T3R commented Sep 8, 2019

Sorry for the absence, didn't have time for MTG for a while. Just fresh installed 2.7.2, Oracle downloaded everything and it's working fine. At least for now it is.

Is this a permanent fix, or is it something that'll eventually have issues in the future as more and more sets come out into Oracle? Since it's a filesize issue and all.

@tooomm
Copy link
Member

tooomm commented Sep 8, 2019

Yes. This could be a potential issue as more and more new sets get released and the file grows in size again. But that will happen more slowly now.

Thanks for reporting back!

@tooomm tooomm closed this as completed Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App - Oracle Tickets relating to the oracle application Defect - Crash OS - Windows Issue specific to windows operating systems
Projects
None yet
Development

No branches or pull requests

6 participants