Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better placement of translation files #4898

Open
tooomm opened this issue Oct 8, 2023 · 0 comments
Open

Better placement of translation files #4898

tooomm opened this issue Oct 8, 2023 · 0 comments
Labels
App - Webclient Tickets relating to the javascript cockatrice webapp Cleanup Translation

Comments

@tooomm
Copy link
Member

tooomm commented Oct 8, 2023

Description of Change
In the webclient, each language has their own folder with a single, identically named file, each containing the translated strings for a different language.
Instead, I would prefer to rename them to use speaking file names, have them all in one folder and therefore also reduce the file path level.
I see no reason why to have individual files with same names in separate folders.

Unless there is some limitation I'm not aware of...

Currently is: webclient/public/locales/<lang>/translation.json

∟ locales
   ∟ es
      ∟ translation.json
   ∟ fr
      ∟ translation.json
   ∟ nl
      ∟ translation.json
   ∟ pt_BR
      ∟ translation.json

Should be: webclient/public/locales/translation-<lang>.json

∟ locales
   ∟ translation-es.json
   ∟ translation-fr.json
   ∟ translation-nl.json
   ∟ translation-pt_BR.json

Changes needed:

  • Webclient code linking the translations
  • Current files with translated strings (names + placement)
  • CI config for pulling translation updates (added paths)
  • Config at Transifex (GitHub Integration)
    • To check:
      • Ressource setup at Transifex?
      • .tx/config file at GitHub
@tooomm tooomm added Cleanup Translation App - Webclient Tickets relating to the javascript cockatrice webapp labels Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App - Webclient Tickets relating to the javascript cockatrice webapp Cleanup Translation
Projects
None yet
Development

No branches or pull requests

1 participant