Issue in Rolling Frequency.

[Anantvijay]

I have integrated the framework and followed the very same steps that was provided in the gitHub home page. i wrote the code as follows:

DDFileLogger _fileLogger = [[DDFileLogger alloc] init];
[fileLogger setRollingFrequency:60_60];
[fileLogger.logFileManager setMaximumNumberOfLogFiles:7];
[fileLogger setMaximumFileSize:3145728];
[DDLog addLogger:fileLogger];
[DDLog addLogger:[DDTTYLogger sharedInstance]];

But the rolling feature doesnt seems to be working. It is still appending logs to the same file even after it crossed an hour's time.
DDLogVerbose(@"%@",[fileLogger.logFileManager logsDirectory]);

[mschmiderer]

Rolling broken for me too.

[rivera-ernesto]

Are you using the latest master version? (:head option id using CocoaPods)

Any idea @dvor ?

[CMoebius]

I am having the same issue with setting the maxim file size and I just now updated to the latest version. Here's my code:

fileLogger = [[DDFileLogger alloc] init];
fileLogger.rollingFrequency = 0; //60 * 60 * 24; // 24 hour rolling
fileLogger.maximumFileSize = 1024 * 512;
fileLogger.logFileManager.maximumNumberOfLogFiles = 7;
[DDLog addLogger:fileLogger];

I want the log files capped at 512K, but when I look at the files using iExplorer, the files just keep getting appended to and grow without limit. As you can see, I used to have this set for 24 hour rolling, but the logs were getting way too big. We upload them to our server if there is an issue and we don't want them to be huge.

[CMoebius]

I also wanted to add that the method to roll the file log is not working:

[fileLogger rollLogFileWithCompletionBlock:^{
}];

[KristinaAtTile]

I'm seeing the same thing -- new log messages being written to the latest log file even if it's beyond the rolling frequency age limit.

From what I can tell, the issue is that DDFileLogger rollLogFileNow sets currentLogFileInfo.isArchived=YES (which is reasonable), but then the next time currentLogFileInfo gets called, we find that mostRecentLogFileInfo.isArchived is true, so we set shouldArchiveMostRecent=NO, and then fall into this code path:

if (!_doNotReuseLogFiles && !shouldArchiveMostRecent) {
    NSLogVerbose(@"DDFileLogger: Resuming logging with file %@", mostRecentLogFileInfo.fileName);
    currentLogFileInfo = mostRecentLogFileInfo;
}

I've hacked this conditional in my own project to add a check for !mostRecentLogFileInfo.isArchived, and now I believe it's working as expected. However I am very new to CocoaLumberjack so I don't know if this may have any unintended side effects.

Hopefully someone who's more familiar with the code can investigate my findings and decide whether this is a legitimate solution.

[rivera-ernesto]

Could you make a pull request so we can discuss the changes there?

[DD-P]

Also broken for me. Git bisect running against RollingTestMac suggested SHA bb167eb

[georgekola]

I am having the same when using the latest master version ( cocoapods with :head). I verified that the bug was introduced by SHA bb167eb as suggested by @DD-P . I have opened a pull request that fixes this issue -- #295

[an0]

Same issue here. Huge log files.

[rspeyer]

I am also experiencing this behavior. It appears, empirically, that as the logs file grows the overall performance of CocoaLumberjack, and my application, declines in a notable way. Is this causal or expected?

[bpoplauschi]

Guys, could you please check this using the latest master? I've merged the pull request from @georgekola and want to make sure this fixes the rolling issue you are having.

[DD-P]

This seems to work correctly now for me (I tested against RollingTestMac). Thank you to @georgekola for the fix.

[dvor]

I've checked - everything is working.

[KimiChiu]

I'm still having this issue.
I'm using CocoaLumberjack/Swift 3.5.1.

let fileLogger: DDFileLogger = DDFileLogger() // File Logger
fileLogger.rollingFrequency = 60 * 60 * 24 // 24 hours
fileLogger.logFileManager.maximumNumberOfLogFiles = 7
fileLogger.maximumFileSize = 1024 * 1024 // 1 Mega bytes

#if DEBUG
DDLog.add(DDOSLogger.sharedInstance, with: .verbose)
DDLog.add(fileLogger, with: .verbose)
#else
DDLog.add(DDOSLogger.sharedInstance, with: .info)
DDLog.add(fileLogger, with: .info)
#endif