Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error on 2.0.0.4 beta #410

Closed
GuyFran opened this issue Dec 3, 2014 · 21 comments · Fixed by #412
Closed

Compile error on 2.0.0.4 beta #410

GuyFran opened this issue Dec 3, 2014 · 21 comments · Fixed by #412

Comments

@GuyFran
Copy link

GuyFran commented Dec 3, 2014

Hi guys.
Since yesterday I'm experiencing this compile error. Maybe remove the "strong" attribute to this one ?

screen shot 2014-12-03 at 11 40 15 am

@rivera-ernesto
Copy link
Member

That line is supposed to be active for deployment targets >= iOS 6.
Maybe you recently changed your deployment target?

@GuyFran
Copy link
Author

GuyFran commented Dec 3, 2014

Actually no, I always started with deployement target >= 7.0.
Weird as I didn't change any settings on the pods. For now I removed the strong attribute to get it to compile.

So this is expected actually ? Hum.

@rivera-ernesto
Copy link
Member

You shouldn't be getting that error and that line should be ok with your deployment target (#397 (comment)).

Can you check the CocoaLumberjack Pod deployment target? Somewhere it is set to iOS 5.

Otherwise if you could share a demo project to reproduce the error would be great.

@rivera-ernesto
Copy link
Member

I got the same error. Seems to happen when using CocoaPods and deployment targets > iOS 5.
Maybe something wrong with the generated Build Settings.

@GuyFran
Copy link
Author

GuyFran commented Dec 3, 2014

Very odd. It's set for 7.0, even for CocoaLumberjack Pod.
I'll keep looking

screen shot 2014-12-03 at 6 34 33 pm

@GuyFran
Copy link
Author

GuyFran commented Dec 3, 2014

Oh and this is my podfile 👍

platform :ios, '7.0'

pod 'AZSocketIO'
pod 'CocoaLumberjack', :git => "https://github.com/CocoaLumberjack/CocoaLumberjack"

@rivera-ernesto
Copy link
Member

Should be fixed.

BTW not sure about your :git => ... option but you can also try with :head.

@GuyFran
Copy link
Author

GuyFran commented Dec 8, 2014

Hum with this pod 'CocoaLumberjack', :git => "https://github.com/CocoaLumberjack/CocoaLumberjack" in my podfile, I still get the error.

If my params for the podfile are incorrect, can you advise me on the proper line so that cocoapods retrieve the latest beta ?

@bpoplauschi
Copy link
Member

I think you need:
pod 'CocoaLumberjack', :head to get the latest master

@GuyFran
Copy link
Author

GuyFran commented Dec 8, 2014

I just gave it a shot but I get some error :

Analyzing dependencies
[!] Unable to satisfy the following requirements:

- `CocoaLumberjack (HEAD)` required by `Podfile`

@bpoplauschi
Copy link
Member

Do you have another pod that has Lumberjack as a dependency?

@GuyFran
Copy link
Author

GuyFran commented Dec 8, 2014

Hum not at all. all the others pods I m using were there BEFORE I added Lumberjack.

@GuyFran
Copy link
Author

GuyFran commented Dec 8, 2014

Well well still no luck. Guess I have a bad karma.

What I did

  • Remove any ref to CocoaLumberjack in my podfile
  • Added the Crashlytics... pod
  • pod update
  • then I commented this line #import "CocoaLumberjack.h" and replaced it with#import "DDTTYLogger.h" that I need for my project.

Sadly the compilation fails giving ld: framework not found Crashlytics clang: error: linker command failed with exit code 1 (use -v to see invocation)

@rivera-ernesto
Copy link
Member

CrashlyticsLumberjack? Then the Podfile you posted is not complete.

@rivera-ernesto
Copy link
Member

Also if you have the latest CocoaLumberjack the line you posted above should look like this:

@interface DDAbstractLogger : NSObject <DDLogger>
{
    // Direct accessors to be used only for performance
    @public
    id <DDLogFormatter> _logFormatter;
    dispatch_queue_t _loggerQueue;
}

@property (nonatomic, strong) id <DDLogFormatter> logFormatter;
@property (nonatomic, DISPATCH_QUEUE_REFERENCE_TYPE) dispatch_queue_t loggerQueue;

@rivera-ernesto rivera-ernesto reopened this Dec 8, 2014
@GuyFran
Copy link
Author

GuyFran commented Dec 8, 2014

Here is my current podfile


platform :ios, '7.0'

pod 'AZSocketIO'
pod 'TMCache'
pod 'StandardPaths'
pod 'FMDB'
#pod 'CocoaLumberjack', :head
#pod 'CocoaLumberjack', :git => "https://github.com/CocoaLumberjack/CocoaLumberjack"
#pod 'CocoaLumberjack', :git => "https://github.com/ValCapri/CocoaLumberjack.git"
pod 'CrashlyticsLumberjack', '2.0.0-beta4'
pod 'FVCustomAlertView'

@rivera-ernesto
Copy link
Member

It does compiles in my test empty project:

platform :ios, '7.0'

pod 'AZSocketIO'
pod 'TMCache'
pod 'StandardPaths'
pod 'FMDB'
pod 'CocoaLumberjack', :head
pod 'CrashlyticsFramework'
pod 'CrashlyticsLumberjack', '2.0.0-beta4'
pod 'FVCustomAlertView'

I added pod 'CrashlyticsFramework' but I think you added the framework differently. Shouldn't matter.

Anyway we should make a new release soon. Probably a first RC @bpoplauschi ?

@GuyFran
Copy link
Author

GuyFran commented Dec 9, 2014

OH I thought I was supposed to remove the original cocoalumberjack from the pod.

Adding those lines to my podfile

pod 'CocoaLumberjack', :head
pod 'CrashlyticsFramework'

it does now compile. Thx for your help

@rivera-ernesto
Copy link
Member

Usually you can if it is required by other pods and you are ok about using the latest stable version.

  • If you want a "pre-release" version (such as 2.0.0-beta4) you need to specify it.
  • If you want to force a certain commit (or head in your case) then you also need to specify it.

CrashlyticsFramework 2.0.0-beta4 requires CocoaLumberjack 2.0.0-beta4, which has the bug you encountered, so you needed to force head on it.

@GuyFran
Copy link
Author

GuyFran commented Dec 17, 2014

Hum now when I try to pod update, I get this message

`CocoaLumberjack/Core (= 2.0.0-beta4)` required by `CrashlyticsLumberjack (2.0.0-beta4)
pod 'CocoaLumberjack', :head
pod 'CrashlyticsFramework'
pod 'CrashlyticsLumberjack', '2.0.0-beta4'

@rivera-ernesto
Copy link
Member

There are newer versions of CrashlyticsLumberjack:

$ pod search CrashlyticsLumberjack

-> CrashlyticsLumberjack (2.0.0-rc2)
   A Crashlytics Logging->CocoaLumberjack Bridge.
   pod 'CrashlyticsLumberjack', '~> 2.0.0-rc2'
   - Homepage: http://github.com/TechSmith/CrashlyticsLumberjack
   - Source:   https://github.com/TechSmith/CrashlyticsLumberjack.git
   - Versions: 2.0.0-rc2, 2.0.0-rc, 2.0.0-beta4, 1.0.2, 1.0.1, 1.0.0 [master repo]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants