Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSPinLock is not safe again #886

Closed
helloyokoy opened this issue Jul 14, 2017 · 3 comments
Closed

OSSPinLock is not safe again #886

helloyokoy opened this issue Jul 14, 2017 · 3 comments
Milestone
3.3.0

Comments

@helloyokoy
Copy link

helloyokoy commented Jul 14, 2017 •
edited

Issue Info

Info Value
Platform Name ios
Platform Version 10.0
CocoaLumberjack Version 3.2.0
Integration Method cocoapods
Xcode Version Xcode 8

OSSpinlock is not safe again ,please use pthread_mutex_t instead!!!

http://blog.ibireme.com/2016/01/16/spinlock_is_unsafe_in_ios/
@chrisamanse chrisamanse mentioned this issue Jul 30, 2017
Merged
8 tasks
@rbrightwell
Copy link

rbrightwell commented Aug 10, 2017 •
edited

Apple has deprecated OSSpinlock. They say to replace it with os_unfair_lock. This is stated in the compiler warnings and also this slide deck, slide number 24.

http://devstreaming.apple.com/videos/wwdc/2016/412jzguxz4h8hykgjlm/412/412_thread_sanitizer_and_static_analysis.pdf

@chrisamanse
Copy link
Contributor

Replaced with pthread_mutex_t in #889. Okay to close?

@bpoplauschi bpoplauschi modified the milestones: Future, 3.3.0 Oct 5, 2017
@bpoplauschi
Copy link
Member

Fixed by #889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
4 participants
@bpoplauschi @rbrightwell @helloyokoy @chrisamanse