Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App rejected due to 2.x.x-rc/-beta CocoaLumberjack framework version #633

Closed
Autoc0diq opened this issue Oct 22, 2015 · 13 comments
Closed

Comments

@Autoc0diq
Copy link
Contributor

Tried to submit app today and ITC rejected it due to invalid version format (-rc) in CocoaLumberjack framework version.

@bpoplauschi
Copy link
Member

That doesn't make sense, for Apple to check the versions of 3rd party libraries. Could you provide a copy-paste or a screenshot with how they sent you this reason? Also, you need to do a pod update since we already have a 2.0.3 version (no rc).

@lawicko
Copy link

lawicko commented Oct 22, 2015

Similar issue I'm seeing when trying to submit the app with 2.1.0-beta:
screen shot 2015-10-22 at 14 13 26

@rivera-ernesto
Copy link
Member

As a workaround you could just change the Build Number (not the version number) of the framework from the Pod project.

I think this should be reported to the CocoaPods project if they don't have an Issue already.

@rivera-ernesto rivera-ernesto changed the title App rejected due to 2.0.0-rc CocoaLumberjack framework version App rejected due to 2.x.x-rc/-beta CocoaLumberjack framework version Oct 22, 2015
@bpoplauschi
Copy link
Member

Even though this issue exists, and it's probably a CocoaPods issue, I must underline something else. Beta releases (as for any product in the world) are not guaranteed and usually have problems. That's why we call it a beta, it's a version people can play with. I think it's a bad practice to submit an app with 3rd party dependencies using beta versions. And CocoaPods handles that, as you can't get a beta version only explicitly. I strongly recommend you stick to 2.0.x until an official 2.1.0 is released. And this recommendation applies to all the other libraries that you use.

@rivera-ernesto
Copy link
Member

On the other hand we thank you for trying out pre-release versions when you're developing.

@sinoru
Copy link
Contributor

sinoru commented Oct 22, 2015

This problem causes by version defined as '2.1.0-beta' or '2.1.0-rc' than '2.1.0' on Info.plist.
And this can be issues using TestFlight requires to upload iTunes Connect.

@lawicko
Copy link

lawicko commented Oct 22, 2015

I noticed the swift2.0 branch was deleted and my app already uses swift 2.0 so I need this badly. The currently released version doesn't support swift 2.0 so I didn't have any choice really. Or perhaps I missed the proper way to deal with swift 2.0 support?

@bpoplauschi
Copy link
Member

Swift 2.0 is now integrated into our master branch and the 2.1.0 release. We already have a beta and a rc 2.1.0, the official 2.1.0 is coming this week.

@Autoc0diq
Copy link
Contributor Author

I didn't use the beta. The 2.0.2 and 2.0.3 official release have the same issue.

On Oct 22, 2015, at 5:51 AM, Bogdan Poplauschi notifications@github.com wrote:

Even though this issue exists, and it's probably a CocoaPods issue, I must underline something else. Beta releases (as for any product in the world) are not guaranteed and usually have problems. That's why we call it a beta, it's a version people can play with. I think it's a bad practice to submit an app with 3rd party dependencies using beta versions. And CocoaPods handles that, as you can't get a beta version only explicitly. I strongly recommend you stick to 2.0.x until an official 2.1.0 is released. And this recommendation applies to all the other libraries that you use.


Reply to this email directly or view it on GitHub.

@rivera-ernesto
Copy link
Member

They can't have that issue if you are using CocoaPods. Otherwise the manual version in the project may be wrong and we need a pull request to update it.

@Autoc0diq
Copy link
Contributor Author

git checkout tags/2.0.2
more Framework/Lumberjack/CocoaLumberjack-Info.plist

CFBundleShortVersionString
2.0.0-rc

@Autoc0diq
Copy link
Contributor Author

We use Carthage not CocoaPods. The version in the Info.plist is the truth.

@bpoplauschi
Copy link
Member

Ok, now it makes sense. I didn't know that (not using Carthage might explain it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants