Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLAide incompatible with RubyGems-3.3.0+ #98

Closed
mikehardy opened this issue Jan 6, 2022 · 6 comments · Fixed by #99
Closed

CLAide incompatible with RubyGems-3.3.0+ #98

mikehardy opened this issue Jan 6, 2022 · 6 comments · Fixed by #99

Comments

@mikehardy
Copy link

mikehardy commented Jan 6, 2022

This was originally logged in Cocoapods main issue list and in the rubygems list (where some great analysis took place, including a reference to the actual bisected commit that caused it)

Logging it here because the actual problem appears to be CLAide here using internals from RubyGems that were unsafe to touch, so an internal refactor of RubyGems for performance triggered a problem here, which transitively breaks cocoapods in combo with ruby-gems-3.3.x

A workaround for affected cocoapods users was posted on the cocoapods issue so users won't get stuck, but it seems to me (could be wrong) that the rubygems change was valid + desired from their perspective and the goal is to fix up CLAide here so it functions with new rubygems versions

That's the context. All technical details referenced out from one comment here: CocoaPods/CocoaPods#11134 (comment)

@mikehardy
Copy link
Author

Cross-linking with upstream issue comment that has the commit reference that CLAide should be able to tolerate:

rubygems/rubygems#5235 (comment)

Option 3 from that comment (fix CLAide) appears to be the preference

@deivid-rodriguez
Copy link
Contributor

I sent a fix for this: #99.

@deivid-rodriguez
Copy link
Contributor

deivid-rodriguez commented Jan 6, 2022

However this repository's CI seems to run on old travis-ci.org which was shutdown. So I guess we need to add a Github Actions configuration to make sure this doesn't break anything. I'll add that now.

@deivid-rodriguez
Copy link
Contributor

deivid-rodriguez commented Jan 6, 2022

To try the fix, you can clone this repository, and run rake install from it, and that should install the patched version of CLAide to your system. That should work fine with rubygems 3.3.x.

@mikehardy
Copy link
Author

@segiddins appears to be the most recent committer 👋 and appears to have actually done some CI work recently

@deivid-rodriguez
Copy link
Contributor

I updated my pull request to migrate CI to Github Actions. It seems all green!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants