New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FBSDKLoginKit can not find headers under 1.0.0 #4713
Comments
Please share a project we can use to debug the issue :) |
All you have to do is create an empty swift project and add "pod 'FBSDKLoginKit" to the Podfile. I did create an empty project that you can see: https://github.com/fcobia/CocoaPodsTest |
Thanks! |
Took a quick look, seems like the issue is that the wrong copy headers build phases are being generated, e.g a "Copy .. Public Headers" which copies most of the SDK's headers into "$(PUBLIC_HEADERS_FOLDER_PATH)/.." |
actually, Facebook’s podspec is wrong |
ah, totally missed that they are using |
The linter already checks for that |
👍 |
(Already as in, as of the 1.0 beta) |
Hi, I updated the header_mappings_dir one level higher which seems to resolve the issue initially,
but it causes non-modular import errors with Cocoapods 0.39 (in a sample that uses FBSDKLoginKit and FBSDKShareKit as well) "/Pods/FBSDKCoreKit/FBSDKCoreKit/FBSDKCoreKit/FBSDKAppLinkResolver.h:26:10: Include of non-modular header inside framework module ‘FBSDKCoreKit.FBSDKAppLinkResolver’ " We've run into this before for different reasons (and it's odd that it breaks in 0.39). I tried a couple things include making Bolts an explicit of our LoginKit and ShareKit as well as removing header_mappings_dir in favor or proper private_header_files without luck. So, for now I'm going to simply set CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES to YES for our LoginKit and ShareKit specs to be compatible for both Cocoapods 0.39 and 1.0-beta2. Let me know if you have other ideas. |
@chrisp-fb this might just be an instance of #4420 |
Interesting thread - but there's definitely something with |
Yah, |
@chrisp-fb Is there any anywhere I can track the work on this? |
FBSDK was working for me in the Beta 1.0 release, but is now broken in the 1.0 release. I have FBSDKShareKit/CoreKit 4.11.0 installed but get the 'FBSDKShareKit/FBSDKShareKit.h' file not found |
Having this issue as well with Cocoapods 1.0 and FBSDKCoreKit 4.12.0 and 4.11.0. |
Having the same issue, please help! |
I'm not able to reproduce the problem and am able to create and build a new swift app with a Podfile that installs all the FBSDK pods correctly. Can you file a report to developers.facebook.com/bugs with additional details like the Podfile and versions of all the tools you're using? If possible, try to include a sample project that reproduces the issue. I'm using Xcode 7.3.1 and Cocoapods 1.0.0 |
This appears to be some issue between CocoaPods and XCode. I tried to reproduce the problem I was seeing with a new project and was unsuccessful. Given that I tried removing the FBSDK from my project entirely. Once the FBSDK was removed I built and now a different Pod was failing to build due to a missing header. At this point I started digging through the active CocoaPod issues and found #4950. The solution seems to be remove all pods, nuke pod cache, nuke XCode's derived data for the project, and reinstall Pods. TL;DR
|
The 1.0.0 beta breaks the Facebook SDK. If you wither include the pod FBSDKCoreKit you can not reference the header files using "#import <FBSDKCoreKit/FBSDKCoreKit.h>."
If you include the pod FBSDKLoginKit, it will not compile because it can not access the FBSDKCoreKit headers.
I downgraded to 0.39.0 and it works with no errors.
The text was updated successfully, but these errors were encountered: