Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on v1.0.0.beta.5: Generating modulemap instead of copying existing one #5177

Closed
1 task done
samnung opened this issue Apr 19, 2016 · 1 comment
Closed
1 task done
Assignees
Labels
d1:easy An easy ticket that is a good start for first-time contributors s4:awaiting validation A Pull Request that is waiting for validation by a CocoaPods Core Team member t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!

Comments

@samnung
Copy link

samnung commented Apr 19, 2016

Report

What did you do?

Installed newer version of CocoaPods. Actually upgraded from v1.0.0.beta.4 to .beta.5.

I am using pod ZSWTaggedString in one project. And I've found that until version 1.0.beta.4 build was working fine, but after upgrading to .beta.5 Xcode can't build it anymore. Xcode is complaining about missing module "ZSWTaggedString.Private".

I've created minimalistic iOS project CocoaPodsModuleExperiment.zip to demonstrate issue.

Steps to recreate the project are very simple:

  • Create some iOS project in Xcode
  • Run pod init
  • Add pod 'ZSWTaggedString/Swift', '~> 2.0' into Podfile
  • Run pod install

From my investigation I think PR #4969 has to do something with this problem, but I am not sure. (And of course I don't want to blame @segiddins 😉). I think it is caused by setting public_headers only in default subspec and using another subspec in Podfile which has dependency on default subspec, well checkout the spec file for ZSWTaggedString.

Important note, during installation verbose mode it tells me that the module map was generated.

Interesting note, when I change Podfile to have following pods, the build works.

pod 'ZSWTaggedString', '~> 2.0'
pod 'ZSWTaggedString/Swift', '~> 2.0'

Now it is copying the modulemap from pod as it should be.

What did you expected to happen?

Xcode build success.

What happened instead?

Xcode build failed.

Podfile

platform :ios, '8.0'
use_frameworks!

target 'CocoaPodsModuleExperiment' do
  pod 'ZSWTaggedString/Swift', '~> 2.0'
end
@segiddins segiddins added the s2:confirmed Issues that have been confirmed by a CocoaPods contributor label Apr 19, 2016
@segiddins segiddins self-assigned this Apr 19, 2016
@segiddins segiddins added t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! d1:easy An easy ticket that is a good start for first-time contributors s4:awaiting validation A Pull Request that is waiting for validation by a CocoaPods Core Team member and removed s2:confirmed Issues that have been confirmed by a CocoaPods contributor labels Apr 19, 2016
@samnung
Copy link
Author

samnung commented Apr 20, 2016

nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d1:easy An easy ticket that is a good start for first-time contributors s4:awaiting validation A Pull Request that is waiting for validation by a CocoaPods Core Team member t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Projects
None yet
Development

No branches or pull requests

2 participants