Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod lint doesn't respect swift_version of dependencies #8940

Closed
1 task done
bobspryn opened this issue Jun 27, 2019 · 10 comments
Closed
1 task done

pod lint doesn't respect swift_version of dependencies #8940

bobspryn opened this issue Jun 27, 2019 · 10 comments
Labels
s2:confirmed Issues that have been confirmed by a CocoaPods contributor s7:workaround available A workaround for the issue is available t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Milestone

Comments

@bobspryn
Copy link

Report

What did you do?

Ran pod lib lint mypod

What did you expect to happen?

Dependencies with different versions of swift to compile with their respective versions and pass linting.

Per discussion here: #8897 (comment)

What happened instead?

Linting failed as it was using the swift version from the main Podspec to compile the dependencies

CocoaPods Environment

Stack

   CocoaPods : 1.7.2
        Ruby : ruby 2.3.7p456 (2018-03-28 revision 63024) [universal.x86_64-darwin18]
    RubyGems : 2.5.2.3
        Host : Mac OS X 10.14.5 (18F203)
       Xcode : 10.2.1 (10E1001)
         Git : git version 2.20.1 (Apple Git-117)
Ruby lib dir : /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib
Repositories : master - https://github.com/CocoaPods/Specs.git @ a551a2a5f25a47ddf704f7937f8c617dd119f56b
          

Installation Source

Executable Path: /usr/local/bin/pod

Plugins

claide-plugins                   : 0.9.2
cocoapods-deintegrate            : 1.0.4
cocoapods-plugins                : 1.0.0
cocoapods-search                 : 1.0.0
cocoapods-static-swift-framework : 0.4
cocoapods-stats                  : 1.1.0
cocoapods-trunk                  : 1.3.1
cocoapods-try                    : 1.1.0

Project that demonstrates the issue

https://twstaticfiles.s3.amazonaws.com/specbug.zip

@dnkoutso
Copy link
Contributor

@sprynmr that is a confirmed bug. Will ship in 1.7.3.

The PR #8897 actually regressed it. Thanks again for filing.

@dnkoutso dnkoutso added this to the 1.7.3 milestone Jun 27, 2019
@dnkoutso dnkoutso added s2:confirmed Issues that have been confirmed by a CocoaPods contributor t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! labels Jun 27, 2019
@dnkoutso
Copy link
Contributor

@sprynmr have you tried CocoaPods 1.7.1?

@bobspryn
Copy link
Author

I haven't, but I will test it now.

@dnkoutso
Copy link
Contributor

Fix #8941

@dnkoutso
Copy link
Contributor

Screen_Shot_2019-06-27_at_1_23_33_PM

Confirmed in my change.

@bobspryn
Copy link
Author

🎉

@bobspryn
Copy link
Author

Confirmed 1.7.1 also does not have the issue.

@dnkoutso
Copy link
Contributor

Cool.

@dnkoutso dnkoutso added the s7:workaround available A workaround for the issue is available label Jun 27, 2019
@dnkoutso
Copy link
Contributor

Will ship with 1.7.3 which also has some improvements for CDN in CocoaPods/Core.

@dnkoutso
Copy link
Contributor

Shipped 1.7.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s2:confirmed Issues that have been confirmed by a CocoaPods contributor s7:workaround available A workaround for the issue is available t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Projects
None yet
Development

No branches or pull requests

2 participants