Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject Podfiles which redefine the platform within the same block #328

Closed
mrackwitz opened this issue May 17, 2016 · 2 comments
Closed

Reject Podfiles which redefine the platform within the same block #328

mrackwitz opened this issue May 17, 2016 · 2 comments

Comments

@mrackwitz
Copy link
Member

Podfile which redefine the platform within the same block in a Podfile should be rejected as invalid. e.g.

platform :ios, '8.0'
pod 'SDWebImage'
platform :ios, '6.1'
pod 'AFNetworking', '~> 3.0'
@segiddins
Copy link
Member

Why is this desirable?

@billychen2014
Copy link

hmm, two questions about such fix.

  1. how to deal with the situation that the platform only can be declared once per block ?As SDWebImage need ios 6.1 but af need 8.0.
  2. IS SDWebImage can work or not because of the platform overwrites?

I did such testing:

  1. tried to declare target twice (i.e.: two blocks) to match the different platform requirement, result is
    [!] The target testSDWeb is declared twice.
    2, test the SDWebImage function ,it looks like it works well, so. it looks like there are some more complex things .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants