Plans for a new version?

[deivid-rodriguez]

Hi!

I upgraded both rubygems & bundler to use the latest and greatest revision of Molinillo:

• Rubygems: Bump vendored molinillo of rubygems to 0.7.0 rubygems/rubygems#3388
• Bundler: Bump vendored molinillo of bundler to 0.7.0 rubygems/rubygems#3402

I was wondering if there are any plans to release the latest changes in the master branch of Molinillo, so we can ship both libraries with Molinillo's code that matches an actual release.

[deivid-rodriguez]

Ping.

[segiddins]

A new version should be released the next time a CocoaPods release happens

[deivid-rodriguez]

Nice, thanks a lot!

I'm watching releases now on https://github.com/CocoaPods/CocoaPods :)

[deivid-rodriguez]

Hi @segiddins! A CocoaPods release happened. Should I expect a new Molinillo release now?

[segiddins]

Cc @dnkoutso did you skip gems during the release?

[dnkoutso]

heh. rainforest does a shallow clone as its initial sync and molinillo did not show up as a gem with new commits. Looking to release today.

[dnkoutso]

Looks like i cant ship 0.7.0 due to a spec failure:

Failures:

  1) Molinillo::Resolver in general raises conflicts with requirement trees
     Failure/Error:
               expect { test_case.resolve(index_class) }.to raise_error(VersionConflict) do |conflict|
                 expect(conflict.message).to eq <<-EOS.strip
       Unable to satisfy the following requirements:
       
       - `json (>= 1.7.7)` required by `berkshelf (2.0.7)`
       - `json (<= 1.7.7, >= 1.4.4)` required by `chef (10.26)`
                 EOS
                 expect(conflict.message_with_trees(:version_for_spec => lambda(&:version))).to eq <<-EOS.strip
       Molinillo could not find compatible versions for possibility named "json":
         In user-specified dependency:
     
       expected: "Unable to satisfy the following requirements:\n\n- `json (>= 1.7.7)` required by `berkshelf (2.0.7)`\n- `json (<= 1.7.7, >= 1.4.4)` required by `chef (10.26)`"
            got: "Unable to satisfy the following requirements:\n\n- `json (>= 1.7.7)` required by `berkshelf (2.0.7)`\n- `json (>= 1.4.4, <= 1.7.7)` required by `chef (10.26)`"
     
       (compared using ==)
     
       Diff:
       @@ -1,5 +1,5 @@
        Unable to satisfy the following requirements:
        
        - `json (>= 1.7.7)` required by `berkshelf (2.0.7)`
       -- `json (<= 1.7.7, >= 1.4.4)` required by `chef (10.26)`
       +- `json (>= 1.4.4, <= 1.7.7)` required by `chef (10.26)`
       
     # ./spec/resolver_spec.rb:180:in `block (3 levels) in <module:Molinillo>'

Finished in 2.48 seconds (files took 0.21279 seconds to load)
260 examples, 1 failure, 1 pending

[dnkoutso]

Not sure if this is a simple update to the spec or something else has changed.

[deivid-rodriguez]

@dnkoutso I think d42b00a should help!

[dnkoutso]

@deivid-rodriguez that commit seems like its changing the order which is causing the spec failure?

[deivid-rodriguez]

Essentially the order of that spec expectations depends on the rubygems version being used by the tests. The current ordering works for rubygems versions lower than 2.7.8 or rubygems versions higher than 3.1.2. If you're using a rubygems version in between it won't work. If we want specs to support those intermediate versions, we'd need to conditionally change the expectation according to the rubygems version being run.

[dnkoutso]

@deivid-rodriguez ah thanks! I missed that part. Trying now.

[dnkoutso]

Shipped! https://github.com/CocoaPods/molinillo/releases/0.7.0

@deivid-rodriguez I am not sure if you can use it though immediately..............at least not with CocoaPods because it is locked with 0.6.6 https://github.com/CocoaPods/CocoaPods/blob/master/cocoapods.gemspec#L39

I need to make one more release of cp 1.10.1 for you to be able to use it and change this requirement

[dnkoutso]

Going to close this now since 0.7.0 shipped. Will update cocoapods separately.

[dnkoutso]

CP Bump PR CocoaPods/CocoaPods#10164

[deivid-rodriguez]

Actually my request was not due to wanting to use the latest Molinillo code with cocoapods, but to get some fixes I added released, so that the code of molinillo that we vendor inside bundler & rubygems matches a released version of molinillo.

Anyways, thanks a lot @dnkoutso for the release! 🎉

[dnkoutso]

nice!