Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of Strike-Out Line is Off #333

Closed
odrobnik opened this issue Mar 7, 2013 · 1 comment
Closed

Position of Strike-Out Line is Off #333

odrobnik opened this issue Mar 7, 2013 · 1 comment
Assignees
Labels
Milestone

Comments

@odrobnik
Copy link
Collaborator

odrobnik commented Mar 7, 2013

At present the strike-out line is positioned in the center of the glyph frame:

y = roundf(runStrokeBounds.origin.y + oneRun.frame.size.height/2.0f + 1)+0.5f;

It would be more correct to position it at half the X-Height.

Since glyph runs have the same font, it should be possible to get the actually used font, get the x-height from that and use this for correct positioning.

@odrobnik
Copy link
Collaborator Author

fixed in 1afd065

@ghost ghost assigned odrobnik Mar 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant