Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Chinese in DTButtonLink Causes Irregular Height #354

Closed
adammlevy opened this issue Mar 20, 2013 · 5 comments
Closed

Using Chinese in DTButtonLink Causes Irregular Height #354

adammlevy opened this issue Mar 20, 2013 · 5 comments
Assignees
Labels
Milestone

Comments

@adammlevy
Copy link

Given the following HTML

<h1>我是个<a href="333">问题</a></h1>

the part in the hyperlink looks lower then the part outside of the HTML after rendering and can be seen in the following screen shot.
Screen Shot 2013-03-19 at 11 29 32 PM

Replacing the same HTML with English doesn't seem to cause this issue.

<h1>I am a<a href="333">problem</a></h1>

Screen Shot 2013-03-19 at 11 33 06 PM

Note: I am just appending this text to your Subviews.html

@odrobnik
Copy link
Collaborator

Please check out the latest version. I totally changed the way hyperlinks are drawn. They now use the same drawing code as the content view.

This should resolve any:

  • blurryness
  • underline problems
  • alignment issues

Please verify and close the issue if you find this to be the case and now looking as it should.

@ghost ghost assigned odrobnik Mar 21, 2013
@odrobnik
Copy link
Collaborator

I'm assuming that this is resolved by the re-implementation.

@adammlevy
Copy link
Author

Thanks for the update. I'll try it out later this week.
Also, is there any way (other then modifying your source code) to not show the underline? Something like dtButton.showsUnderline = NO.

@odrobnik
Copy link
Collaborator

The button does not control the display any more. You need to set a CSS style for no decorafion or use the parsing option for the link decoration style.

@adammlevy
Copy link
Author

Thanks! I'll give that a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants