Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with the KL term computation #3

Open
benolmbrt opened this issue Nov 29, 2023 · 1 comment
Open

Potential issue with the KL term computation #3

benolmbrt opened this issue Nov 29, 2023 · 1 comment

Comments

@benolmbrt
Copy link

Hello,

Thanks for sharing your work. I noticed something strange with the computation of the KL term and wondered if you can maybe clarify this point.

More particularly the KL term is computed using : alp = E * (1 - label) + 1 (criterions.py line 453)
where E is the evidence. This does not correspond to the formula presented in the paper (Eq 11)
where alp is defined as : alp = alpha * (1-label) + label

image

Best regards
Benjamin

@Cocofeat
Copy link
Owner

Thanks for your interest in this work, you are right, in this formula should be alp = alpha * (1-label) + label. First of all, for the problem of alpha, in the supervision, it is actually effective for both E and alpha supervision, but in practice, I find that direct supervision may be more effective for E. In addition, the problem with +label and +1 is actually similar, because the label or mask area is 1. We will further explain this formula and problem in the journal version. Thank you again for pointing out our problem and your interest in this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants