Portable mac builds #2463
Merged
Portable mac builds #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkase
changed the title
bkase
changed the title
bkase
force-pushed
the
test-dist-ci
branch
4 times, most recently
from
3e5588f
to
a1b90f9
Compare
This reverts commit 2892fb1.
emberian
reviewed
May 17, 2019
|
|
||
| # | ||
| # ONLY USED FOR DEBUGGING | ||
| # Use this script to verify that dist builds build on other machines |
emberian
reviewed
May 17, 2019
| DIST_ZIP="" | ||
| BUCKET="" | ||
|
|
||
| curl "https://s3-us-west-2.amazonaws.com/$BUCKET/$DIST_ZIP" > "$DIST_ZIP" |
There was a problem hiding this comment.
Do we need to hardcode the region name? Also, isn't this URL scheme deprecated?
emberian
approved these changes
May 17, 2019
bkase
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portable mac builds across same version or newer of your Xcode tools.
make macos-distcreates a_build/dist.zipthat can be sent to other macOS machines and correctly execute coda.exe even in the presence of older CPUs.RocksDB fortunately included a
PORTABLEoption in its makefile, so I've enabled that while also turning on sse4.2 which is available for over 10 years.Libsnark changes were handled in o1-labs/snarky#252 .
scripts/macos-dist.shis the main workhorse for correcting dylib loading.Tested by building dist builds locally and pushing them to an s3 bucket and pulling from CircleCI machines. I included the test script I was using
scripts/get-and-run-dist-coda.shfor future potential debugging. However, there is currently no CI checking that the dist builds remain in working order nor is there any job for creating such dist builds. Perhaps, this can be tackled when we re-enable the build-macos job.