Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genesis timestamp hotfix #3139

Merged
merged 3 commits into from Aug 8, 2019
Merged

Genesis timestamp hotfix #3139

merged 3 commits into from Aug 8, 2019

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Aug 8, 2019

As discussed with Joel on discord, this bumps the genesis time to 9AM today.

Checklist:

  • Tests were added for the new behavior
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

jkrauska
jkrauska approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@jkrauska jkrauska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hot

@mrmr1993 mrmr1993 requested a review from emberian as a code owner August 8, 2019 13:13
jkrauska
jkrauska reviewed Aug 8, 2019
View reviewed changes
scripts/pvkeys-download.sh Outdated
@@ -31,10 +31,14 @@ set +e
PR_NUMBER=`basename ${CIRCLE_PULL_REQUEST:-NOPR}`
GH_API="https://api.github.com/repos/CodaProtocol/coda/pulls"
MERGE_INTO_BRANCH=`curl -s ${GH_API}/${PR_NUMBER} | jq -r .base.ref`
CIRCLE_BRANCH_NOSLASH=$( echo ${CIRCLEBRANCH} | sed 's!/!-!; s!!-!g' )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo needs _

@jkrauska jkrauska merged commit ce3da11 into release/0.0.1-beta.2 Aug 8, 2019
bkase pushed a commit that referenced this pull request Aug 8, 2019
@mrmr1993 @bkase
Genesis timestamp hotfix (#3139)
d362839 
* Genesis timestamp hotfix
* Use escaped slash branch names for finding PV keys
bkase pushed a commit that referenced this pull request Aug 8, 2019
@mrmr1993 @bkase
Genesis timestamp hotfix (#3139)
dec2a38 
* Genesis timestamp hotfix
* Use escaped slash branch names for finding PV keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrauska jkrauska jkrauska approved these changes

@imeckler imeckler Awaiting requested review from imeckler

@nholland94 nholland94 Awaiting requested review from nholland94

@emberian emberian Awaiting requested review from emberian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrmr1993 @jkrauska