Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export history in a csv #80

Closed
Golden-VS opened this issue Apr 12, 2018 · 13 comments · Fixed by #209
Closed

Export history in a csv #80

Golden-VS opened this issue Apr 12, 2018 · 13 comments · Fixed by #209

Comments

@Golden-VS
Copy link

After DEXBot has been running for multiple hours, one would want to analyze the trades made. To make that possible in the most simple fashion, would be just to save all trades (under "my trades" section) to a xls/csv file.

@MarkoPaasila
Copy link
Collaborator

I suggested a format in issue #11 . Would you mind having a look at it if it serves the purpose?

@Golden-VS
Copy link
Author

Looks great. I would add 1 extra column showing base value. So if an asset is sold for 1000 (BTS) also show the corresponding base value (USD) in separate column.

And if these data are also saved to file, perfect!

@MarkoPaasila
Copy link
Collaborator

@Golden-VS if the sell amount and buy amount are there, you can derive price from it, cant you? I just happen to think keeping things as simple an minimal as possible, but not any more, is good in general.

@Golden-VS
Copy link
Author

Oh i see it now, you create a separate row for both sides of the transaction. I suggest 1 row and one extra column. I think that would be even cleaner. But your method works fine now i see it.

@MarkoPaasila
Copy link
Collaborator

If you put the whole trade in one row, you will sometimes get the BTS increase/decrease in the third column and sometimes in the fifth, because it's impossible to force it either way. That will make it harder to use in a spreadsheet (I think).

If you have all the amounts (plus and minus) in one column, you can filter by asset and by action type, and have all the trades in one column.

What if we had all the negative amounts (sell) in the third column and positive in the fifth?

I don't know if it makes much difference.

@Golden-VS
Copy link
Author

What if you would have these columns:
Action, ID, Quote, Amount, Base, Amount, Date.
Example:
Fill order, 1234566788, BTS, -100, USD, 6.5436, 14042018

Wouldnt this always work? And this way every row always holds the whole transaction information.

@MarkoPaasila
Copy link
Collaborator

It would work. I'm just thinking of how to add a column when analyzing by hand, which

@Golden-VS
Copy link
Author

your previous comment is incomplete :)

@MarkoPaasila
Copy link
Collaborator

MarkoPaasila commented Apr 16, 2018

I was in a hurry :-)
I agree that it is better on one line. I was just thinking of how easy it is to analyze in a spreadsheet. If I make one column for each asset balance it can be updated with a few "SUMIF's", even though the same asset might be in column 4 or column 6. So lets agree. One line per actionl

@Golden-VS
Copy link
Author

agreed :)

@MarkoPaasila
Copy link
Collaborator

MarkoPaasila commented Jun 12, 2018

So I think the best format for export would be what I suggested in #11:

ACTION ID AMOUNT ASSET TIME
Place order 1.11.42343463423 -100.00000 BTS [datetime]
Place order 1.11.42343463423 12.34567 USD [datetime]
Fill order 1.11.34594809723409 -50.00000 BTS [datetime]
Fill order 1.11.34594809723409 6.16049 USD [datetime]
Cancel order 1.11.3242390840293
Transfer 1.11.4234463423 +100.00000 BTS [datetime]

This will leave the user the option of analyzing strategy or profitability by filtering out the unnecessary action types. I also think it's more useful to separate trades into 2 lines; one for each asset. That is likely the most simple way of ensuring the same asset will always be in the same column. If they are in two or more columns, it makes analysis a little more difficult. But that's not a strong opinion and if it's easier to export a trade on a single line then lets do it that way.

@MarkoPaasila
Copy link
Collaborator

This requires #204

@MarkoPaasila
Copy link
Collaborator

Just for reference; history export isn't complete, but it's MVP and will likely be further enhanced in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants