New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export history in a csv #80
Comments
I suggested a format in issue #11 . Would you mind having a look at it if it serves the purpose? |
Looks great. I would add 1 extra column showing base value. So if an asset is sold for 1000 (BTS) also show the corresponding base value (USD) in separate column. And if these data are also saved to file, perfect! |
@Golden-VS if the sell amount and buy amount are there, you can derive price from it, cant you? I just happen to think keeping things as simple an minimal as possible, but not any more, is good in general. |
Oh i see it now, you create a separate row for both sides of the transaction. I suggest 1 row and one extra column. I think that would be even cleaner. But your method works fine now i see it. |
If you put the whole trade in one row, you will sometimes get the BTS increase/decrease in the third column and sometimes in the fifth, because it's impossible to force it either way. That will make it harder to use in a spreadsheet (I think). If you have all the amounts (plus and minus) in one column, you can filter by asset and by action type, and have all the trades in one column. What if we had all the negative amounts (sell) in the third column and positive in the fifth? I don't know if it makes much difference. |
What if you would have these columns: Wouldnt this always work? And this way every row always holds the whole transaction information. |
It would work. I'm just thinking of how to add a column when analyzing by hand, which |
your previous comment is incomplete :) |
I was in a hurry :-) |
agreed :) |
So I think the best format for export would be what I suggested in #11:
This will leave the user the option of analyzing strategy or profitability by filtering out the unnecessary action types. I also think it's more useful to separate trades into 2 lines; one for each asset. That is likely the most simple way of ensuring the same asset will always be in the same column. If they are in two or more columns, it makes analysis a little more difficult. But that's not a strong opinion and if it's easier to export a trade on a single line then lets do it that way. |
This requires #204 |
Just for reference; history export isn't complete, but it's MVP and will likely be further enhanced in the future. |
After DEXBot has been running for multiple hours, one would want to analyze the trades made. To make that possible in the most simple fashion, would be just to save all trades (under "my trades" section) to a xls/csv file.
The text was updated successfully, but these errors were encountered: