-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature #10 tests done successfully and snapshots added #30
feature #10 tests done successfully and snapshots added #30
Conversation
@KishkinJ10 Use the url of photos in <img src " "> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please give space between different lines
Sir please check the changes made :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement the following:
- Errors set on textfields like Email cannot be empty, constraints on password in Sign Up(like min 8 digits, special character etc)
- Tests for Resend verification email
- Tests for Forgot Password
Sir please check the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add tests for Confirm Password, also if email has already been verified a toast saying "Email address already verified" is displayed on clicking Resend Verification Email, for forgot password, entering email address is mandatory, a toast is shown if email is empty
<img src="TestSignUpAndSignIn_Snapshots/Password_Conatraint1_FitMate.jpg" width="300"/><br> | ||
<br> | ||
<img src="TestSignUpAndSignIn_Snapshots/Password_Constraint2_FitMate.jpg" width="300"/><br> | ||
_Expected Result_: Password must contain atleast one special character and minimum 8 digits<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Password must also contain a letter and a digit
@KishkinJ10 Use the URL properly |
@KishkinJ10 While working on testing issues, try to cover every possible test you can think of . The main motive is to see whether the feature is working positively for each and every scenario. TRY CRASHING THE APP You can note down every possibility first and then make test cases based on that, this will help you to cover more scenarios. |
@SHITIZ-AGGARWAL @Acash512 Sir I have added all the test which I could have thought of , sir mostly all the tests are covered . Sir please merge this PR :) |
@KishkinJ10 good work |
@SHITIZ-AGGARWAL @yatharthmago01 @Acash512 Thank you sir for guiding me. |
Description
<This PR is regarding a feature request #10 in which test have been done successfully to check sign IN and sign-up functionality and screenshots have been added>
Related Issue
Fixes #10
Type of Contribution:
Checklist:
I have read README.md and CONTRIBUTION.md
My code/design follows the style/guidelines of this project.
I have performed a self-review of my own code/design/documentation.
I have commented my code, particularly in hard-to-understand areas(or gave a proper description about the design).