Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chocolatey/Squirrel support. #452

Open
devkhan opened this issue May 31, 2015 · 12 comments
Open

Add chocolatey/Squirrel support. #452

devkhan opened this issue May 31, 2015 · 12 comments

Comments

@devkhan
Copy link

devkhan commented May 31, 2015

Please add installation via the chocolatey package manger, if possible.

@JakeGinnivan
Copy link
Member

Would you like to have a go at a pull request? :)

@devkhan
Copy link
Author

devkhan commented Jun 1, 2015

I'm sorry, but I didn't understand. Also, I don't know how to create a chocolatey package but I'll try and hopefully open a pull request.

But I just wanted to know if that is even possible in this project as this application installs as a ClickOnce app. So, I want to conform that is it possible or not, then I'll try creating a package on my own.

Thank You 👍

@JakeGinnivan
Copy link
Member

What would be good is https://github.com/Squirrel/Squirrel.Windows for updates.

Then chocolatey would be the initial install then squirrel would take over, just like Atom editor from github. @shiftkey what are the best resources to read up about doing this?

@devkhan
Copy link
Author

devkhan commented Jun 1, 2015

I think that can cause problems for both the user and the developer. Doesn't the developer has to configure his application to be deployed via two different ways, also the user can get confused(can't get the right word here) if s/he has to use two different ways.

Why don't we choose any one and only whether it be chocolatey or Squirrel?
Or are there any pros and cons of one over other in the context of this app?

P.S. - I just found out you are already hosting MarkPad in chocolatey gallery, then why did you asked me for a pull request?

@JakeGinnivan
Copy link
Member

P.S. - I just found out you are already hosting MarkPad in chocolatey gallery, then why did you asked me for a pull request?

I forgot about that, I assumed we didn't have it because you opened this issue :)

Squirrel has in app updates which is quite nice, rather than having to drop to the command line.

@devkhan
Copy link
Author

devkhan commented Jun 1, 2015

Okay, as you already have chocoloatey support, I'll try to work on Squirrel. Since I'm new to this, please bear with me if it gets late or not done properly. 🙇

@shiftkey
Copy link
Member

shiftkey commented Jun 1, 2015

@shiftkey what are the best resources to read up about doing this?

Start here: https://github.com/Squirrel/Squirrel.Windows/blob/master/docs/getting-started.md

@devkhan devkhan changed the title Add chocolatey support. Add chocolatey/Squirrel support. Feb 11, 2016
@devkhan
Copy link
Author

devkhan commented Feb 11, 2016

Sorry, for not replying after such a long time.
After getting some time, I did searched around a bit and found out that Squirrel supports only .NET >=4.5. So, the project either needs to be re-targeted for 4.5 or Squirrel support cannot be added right now.

@shiftkey
Copy link
Member

Let's retarget to 4.5. Even though it's no longer supported for security updates (and Windows XP doesn't support 4.5) I think it's a reasonable thing to do.

@devkhan
Copy link
Author

devkhan commented Feb 12, 2016

I don't whether that was sarcasm or not, but AFAIK, support for .NET4 (current target) has also already ended. Also, not many users of this app(or any other app) are on XP.

And to be on the safe side, we can re-target to 4.5.2, which will be supported till Windows 8.1 Update. (I really don't know much about which framework to target.)

@shiftkey
Copy link
Member

@devkhan I wasn't meaning to be sarcastic there - apologies if it came across as such.

The reason why I suggest 4.5 is that there's an open issue with Squirrel bootstrapping for versions of the .NET Framework beyond 4.5 - which potentially means users won't get the right version of the framework and the app won't launch.

Squirrel/Squirrel.Windows#188 discusses the options available to workaround this. None of it's easy at this point 😢

@devkhan
Copy link
Author

devkhan commented Feb 12, 2016

Thanks @shiftkey for clearing it out. I'm also sorry if I came across as taking any shots.

I will take a look at it and see what are the possibilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants