Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery-cookie / js-cookie issue #741

Closed
stevengliebe opened this issue Dec 7, 2018 · 3 comments
Closed

jquery-cookie / js-cookie issue #741

stevengliebe opened this issue Dec 7, 2018 · 3 comments
Assignees
Labels

Comments

@stevengliebe
Copy link

Hello,

I'm seeing that the jquery-cookie.js file is enqueued with the 'jquery-cookie' handle. This is fine. The problem is that the contents of jquery-cookie.js are not actually jQuery Cookie. They're JavaScript Cookie, which is not just a newer version; it's a different script with different use.

This is creating conflicts with other plugins and themes that expect the old jQuery Cookie script to be enqueued as expected when using the 'jquery-cookie' handle. Can you please rename the handle (and file) to prevent conflicts like this?

Thank you.

@PerryRylance
Copy link
Contributor

Hi Steven

Thank you very much for reporting this, we will be making this alteration and releasing a patch in the next few days.

Kind regards

  • Perry

@PerryRylance PerryRylance self-assigned this Dec 10, 2018
@stevengliebe
Copy link
Author

Thank you. That will be helpful. I've seen a conflict in three different situations now.

@PerryRylance
Copy link
Contributor

We've changed the handle to javascript-cookie in 7.10.51, which should be going out shortly, thanks again for letting us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants