Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Achieve 100% coverage tests for src/value folder #37

Closed
joojis opened this issue Nov 20, 2018 · 0 comments · Fixed by #41
Closed

Achieve 100% coverage tests for src/value folder #37

joojis opened this issue Nov 20, 2018 · 0 comments · Fixed by #41
Labels
good first issue Good for newcomers test

Comments

@joojis
Copy link
Contributor

joojis commented Nov 20, 2018 •
edited
Loading

https://codecov.io/gh/Codechain-io/codechain-primitives-js/tree/master/src/value

image

-> expect fromBytes ... [0x96, 0x10, ...] to equal new H128("0x10...")

image

-> expect to throw: new U64(new BigNumber("0xFFF....FFF"))

image

-> expect to be false: U64.check(new BigNumber("-1")) ...
@joojis joojis added good first issue Good for newcomers test labels Nov 20, 2018
@joojis joojis mentioned this issue Dec 1, 2018
Merged
@joojis joojis closed this as completed in #41 Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase test coverage joojis/codechain-primitives-js
1 participant
@joojis