New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pinia-orm): proper exports for collection and uid helpers #1681
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1681 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 86 86
Lines 5873 5873
Branches 494 494
=======================================
Hits 5864 5864
Misses 6 6
Partials 3 3 β View full report in Codecov by Sentry. |
So, I was wrong about that. Rollup has failed when I tried to import helpers the "old way" (with "./dist/*": {
"types": "./dist/*.d.ts",
"require": "./dist/*.cjs",
"import": "./dist/*.mjs"
},
"./*": {
"types": "./dist/*.d.ts",
"require": "./dist/*.cjs",
"import": "./dist/*.mjs"
} WDYT? |
yes i think the same. Just had the same issue....also types dont work without "dist" correctly |
That's weird. Modern versions of TS know how to parse |
I am using TS 5.2.2 and "moduleResolution": "node". So all fine. I think i have to create the folders with an index.ts file like "decorators/index" in the root. I think that then it will work. |
FYI: I found out that it's most likely Your idea with folders sounds fine if Pinia ORM really need to support legacy versions of Node... which I think not supported currently anyway. |
π Linked issue
#1680
β Type of change
π Description
Resolves #1680.
All imports are now possible without specifying
dist
folder.For those who used
dist
and it worked for them - it should still work too (I think).Docs updated accordingly (all
dist
references removed).π Checklist