Make status bar an actual divider #1731
Draft
+36
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this include your work with #1701? I noticed that it was closed. |
|
Yes, the goal is to eventually integrate the changes from #1701, but I want to iron out the status bar first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the status bar was just attached to the bottom of the editor, whereas in Xcode, it acts essentially as a thick divider. This PR aims to get the status bar to be more like Xcode's.
Relevant SO article: https://stackoverflow.com/questions/40643604/can-i-use-a-custom-view-as-a-nssplitviews-divider/40659541
Related Issues
Checklist
Screenshots
As shown in the video below, normal drags + collapsing the editor work fine, but for some reason collapsing the terminal causes really jank behavior.
Screen.Recording.2024-05-22.at.2.43.57.PM.mov