Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Editor/Terminal Color Themes #189

Closed
austincondiff opened this issue Mar 22, 2022 · 5 comments
Closed

✨ Editor/Terminal Color Themes #189

austincondiff opened this issue Mar 22, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request source editor terminal UI This is UI related

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 22, 2022

Let's create our own set of pre-bundled themes.

  • We can provide similar ones to what Xcode comes with along with a few of our own.
  • Each theme will have the option to have a light mode and a dark mode that can optionally change when the user switches light/dark mode.
  • We will have a setting to use the themes background, or use the standard window background which is tinted by your wallpaper.
  • We can also provide "smart themes" which generate a theme based on the users tint color (See ✨ Automatically Generated Color Themes based on window tint color #46)
  • We might leverage some work being done in 👀 Extension Architecture / API #76.

Related issue #187.

Questions

  • Will themes each be extensions like in VSCode or will they be separate from themes in some way?
@lukepistrol lukepistrol added enhancement New feature or request UI This is UI related labels Mar 23, 2022
@underthestars-zhy
Copy link

We could create a theme standard. And people can add their theme. It should be separated from the extension

@Jeehut
Copy link
Contributor

Jeehut commented Mar 27, 2022

I like the idea of adding color themes for syntax highlighting. But I think "smart themes" based on wallpaper background or tint color should be the second or third step. First, we should provide a decent set of popular theming styles, including some that have really good contrast for accessibility. Next, we should build a custom theme editor so users can duplicate the existing and adjust them to their needs. After that, we could make them export- and importable (e.g. as JSON files).

Also, the default theming style should be one that's popular and that has a good contrast. The current one is actually quite hard to read, I also don't like the color style (which is subjective, but I'm using the default anywhere else so I'm not very demanding), see here for example:
Screenshot 2022-03-27 at 14 51 55

@austincondiff austincondiff mentioned this issue Mar 31, 2022
15 tasks
@austincondiff austincondiff changed the title Syntax Highlighting Themes [FEAT] - Custom Theming Mar 31, 2022
@austincondiff austincondiff changed the title [FEAT] - Custom Theming ✨ Custom Theming Mar 31, 2022
@stale stale bot added wontfix This will not be worked on and removed wontfix This will not be worked on labels May 30, 2022
@CodeEditApp CodeEditApp deleted a comment from stale bot Jun 1, 2022
@stale stale bot added the wontfix This will not be worked on label Aug 1, 2022
@CodeEditApp CodeEditApp deleted a comment from stale bot Aug 1, 2022
@stale stale bot removed the wontfix This will not be worked on label Aug 1, 2022
@austincondiff austincondiff changed the title ✨ Custom Theming ✨ Editor/Terminal Color Themes Sep 28, 2022
@austincondiff
Copy link
Collaborator Author

@CodeEditApp/admins what do we want to do with this issue? We have some themes, could we create new issues for future work?

@iggy890
Copy link
Contributor

iggy890 commented Mar 6, 2023

This seems like an issue that is hard to fix, SwiftTerm which is the package we're using is no longer receiving updates. We should either create a fork of SwiftTerm and edit that fork or change package.

@matthijseikelenboom
Copy link
Contributor

What makes you say that the project isn't receiving updates anymore? The latest commit was 4 days ago?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request source editor terminal UI This is UI related
Projects
Status: 🏁 Complete
Development

No branches or pull requests

6 participants