Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Open Quickly Overlay #42

Closed
3 of 4 tasks
Tracked by #346
austincondiff opened this issue Mar 17, 2022 · 7 comments · Fixed by #119
Closed
3 of 4 tasks
Tracked by #346

✨ Open Quickly Overlay #42

austincondiff opened this issue Mar 17, 2022 · 7 comments · Fixed by #119
Assignees
Labels
enhancement New feature or request UI This is UI related

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 17, 2022

  • Decide on a keyboard shortcut to use to evoke a quick open search bar.
    • Xcode: Cmd+Shift+O
    • VS Code, Atom, Sublime Text: Cmd+Opt+P
  • Build search bar similar to Apple Spotlight or Xcode quick open
  • Build file list of search results
  • Keyboard navigation to navigate list and select option, or escape

05-macOS-code-edit-file-search

06-macOS-code-edit-file-search-filled

@austincondiff austincondiff added the enhancement New feature or request label Mar 17, 2022
@lukepistrol
Copy link
Member

I like cmd + Shift + O more

@austincondiff
Copy link
Collaborator Author

Let's do it then since we are trying to steer closer to Xcode rather than VS Code. We can always develop an extension that provides VS Code key bindings.

@viktorstrate
Copy link

Potentially relevant WWDC about creating child windows and sending events between windows.

https://developer.apple.com/devcenter/download.action?path=/videos/wwdc_2010__hd/session_145__key_event_handling_in_cocoa_applications.mov

@lukepistrol lukepistrol added the UI This is UI related label Mar 20, 2022
@pkasila
Copy link
Member

pkasila commented Mar 20, 2022

I'll try to implement it

@pkasila pkasila self-assigned this Mar 20, 2022
@pkasila pkasila mentioned this issue Mar 20, 2022
@pkasila pkasila reopened this Mar 20, 2022
@pkasila
Copy link
Member

pkasila commented Mar 20, 2022

I've reopened this issue because keyboard navigation works for the list, but some changes should be done. Because at the moment I haven't figured out how to implement great keyboard navigation to switch between list and search field and open files (not just switch in the panel's NavigationView).

@austincondiff
Copy link
Collaborator Author

austincondiff commented Mar 21, 2022

Very nice! We might use some of the same components for the command palette. Just a few more things before we can close this issue...

  • Padding, spacing, font-sizes and dimensions are slightly off, please refer to the figma concept for exact specifications.
  • The bottom half of the overlay should be hidden if there is no characters in the input. Just like spotlight.
  • The vertical separator should be the same color as the horizontal separator.

@lukepistrol lukepistrol changed the title Quick open search bar overlay [FEAT] - Quick open search bar overlay Mar 21, 2022
@pkasila
Copy link
Member

pkasila commented Mar 23, 2022

@austincondiff Maybe it would be better to close this issue and create new one for "The vertical separator in Open Quickly should be the same color as the horizontal separator"?

@austincondiff austincondiff changed the title [FEAT] - Quick open search bar overlay ✨ Quick open search bar overlay Mar 31, 2022
@austincondiff austincondiff mentioned this issue May 25, 2022
12 tasks
@austincondiff austincondiff changed the title ✨ Quick open search bar overlay ✨ Open Quickly Overlay Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI This is UI related
Projects
Status: 🏁 Complete
Development

Successfully merging a pull request may close this issue.

4 participants