Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lodash #50

Open
Alex-Cannon opened this issue Oct 28, 2019 · 1 comment
Open

Remove Lodash #50

Alex-Cannon opened this issue Oct 28, 2019 · 1 comment
Labels
feature New feature or request

Comments

@Alex-Cannon
Copy link
Collaborator

As @airandfingers pointed out, lodash is used once in the project in the file src/pages/categories/index.jsx. We can easily create a uniqBy utility to replace Lodash's and reduce our package size.

@Vpr99 I'd like your input before we remove this. We may have plans to use Lodash in the future.

@Alex-Cannon Alex-Cannon added the feature New feature or request label Oct 28, 2019
@airandfingers
Copy link
Contributor

Note that if we want to keep lodash in, we should use one of a few ways to import that cause Webpack to only include the code that we actually use: https://stackoverflow.com/a/43479515/877682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants