Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hover text in inputs #269

Closed
jlubken opened this issue Mar 26, 2020 · 1 comment · Fixed by #283
Closed

Fix hover text in inputs #269

jlubken opened this issue Mar 26, 2020 · 1 comment · Fixed by #283
Assignees
@ecsmyth
Labels
bug Something isn't working python quickfix
Projects
App Platform

Comments

@jlubken
Copy link
Collaborator

jlubken commented Mar 26, 2020

The hover text is inaccurate. For example for a value of 2.5, 'Hospitalization %' states: "Please enter a valid value. The two nearest valid values are 2.001 and 3.001"

I think the text is generated from the step parameter. Which isn't a bad value, but it is being used to generate the misleading text. Any other options we can add to the st.number_input to fix this?
@jlubken jlubken created this issue from a note in App Platform (Platform 1.0 (streamlit)) Mar 26, 2020
@jlubken jlubken added bug Something isn't working python quickfix labels Mar 26, 2020
@kmid5280
Copy link
Contributor

What would the text ideally say?

@ecsmyth ecsmyth mentioned this issue Mar 27, 2020
Merged
@ecsmyth ecsmyth self-assigned this Mar 27, 2020
@ecsmyth ecsmyth moved this from Platform 1.0 (streamlit) to Platform In Progress in App Platform Mar 27, 2020
@ecsmyth ecsmyth moved this from Platform In Progress to Platform Done in App Platform Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecsmyth ecsmyth

Labels
bug Something isn't working python quickfix
Projects
App Platform
Platform Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates to number input step, min val, and types CodeForPhilly/chime
3 participants
@jlubken @ecsmyth @kmid5280