Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

["bug"] Improve Dockerfile layer caching #286

Closed
ecsmyth opened this issue Mar 27, 2020 · 0 comments · Fixed by #283
Closed

["bug"] Improve Dockerfile layer caching #286

ecsmyth opened this issue Mar 27, 2020 · 0 comments · Fixed by #283
Assignees
Labels
bug Something isn't working

Comments

@ecsmyth
Copy link
Collaborator

ecsmyth commented Mar 27, 2020

Description:

The current order of steps in the Dockerfile has some expensive infrequent tasks (e.g., pip install -q .) occurring after more frequently modified file are copied (e.g., src). The breaks layer caching and causes image builds to take longer than necessary.

Steps to reproduce:

  1. Run ./script/server
  2. Modify a file in ./src
  3. Run ./script/update

Expected behavior:

The step RUN pip install -q . is cached

What I got instead:

The step RUN pip install -q . needs to execute

@ecsmyth ecsmyth added the bug Something isn't working label Mar 27, 2020
@ecsmyth ecsmyth added this to Inbox, Unprocessed in App Platform via automation Mar 27, 2020
@ecsmyth ecsmyth moved this from Inbox, Unprocessed to Platform In Progress in App Platform Mar 27, 2020
@ecsmyth ecsmyth self-assigned this Mar 27, 2020
@ecsmyth ecsmyth linked a pull request Mar 27, 2020 that will close this issue
@ecsmyth ecsmyth moved this from Platform In Progress to Platform Done in App Platform Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
App Platform
Platform Done
Development

Successfully merging a pull request may close this issue.

1 participant