fix: fix aws api gateway v2 event source cookies handling #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WarFox
reviewed
Mar 17, 2021
Comment on lines
66
to
67
| responseToApiGateway.cookies = headers['set-cookie'] | ||
| responseToApiGateway.cookies = Array.isArray(headers['set-cookie']) ? headers['set-cookie'] : [headers['set-cookie']] | ||
| delete headers['set-cookie'] |
There was a problem hiding this comment.
may be we can remove some repeated code
if(cookies = headers['set-cookie']) {
responseToApiGateway.cookies = Array.isArray(cookies) ? cookies: [cookies]
delete headers['set-cookie']
}There was a problem hiding this comment.
Thank you for your reviewing.
I refactored and push it.
Can you check it again? thank you.
There was a problem hiding this comment.
thank you, looks good to me
There was a problem hiding this comment.
Please fix the failing tests
brett-vendia
approved these changes
May 11, 2021
github-actions bot
pushed a commit
that referenced
this pull request
May 11, 2021
## [4.3.5](v4.3.4...v4.3.5) (2021-05-11) ### Bug Fixes * fix aws api gateway v2 event source cookies handling ([#389](#389)) ([6e0868c](6e0868c))
|
🎉 This PR is included in version 4.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
OneDev0411
added a commit
to OneDev0411/serverless-express
that referenced
this pull request
Mar 16, 2023
## [4.3.5](CodeGenieApp/serverless-express@v4.3.4...v4.3.5) (2021-05-11) ### Bug Fixes * fix aws api gateway v2 event source cookies handling ([#389](CodeGenieApp/serverless-express#389)) ([6e0868c](CodeGenieApp/serverless-express@6e0868c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Issue #388
Description of changes:
Change AWS API Gateway v2 event source
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.