Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty parens when no assignments present in Current Grade Information UI #173

Open
andyscho opened this issue Feb 1, 2020 · 0 comments
Open

Comments

@andyscho
Copy link

andyscho commented Feb 1, 2020

This feels like a nitpick UI issue that may be subjective, so feel free to close this issue if it is intended behavior or there is any disagreement.

Currently, when there are not any homeworks that have not yet been submitted, a pair of empty parens are present.

Screen Shot 2020-02-01 at 12 53 57 PM

As they are unlabeled, it doesn't necessarily seem immediately intuitive to users that these unlabeled empty parens represent the empty list of the names of assignments that fall under Homeworks not yet submitted. Showing these parens also seems like potentially redundant information given that the weighting of 0.00 is already shown in the case that there are no assignments present.

I propose not showing any parens when stats[:unsub_names] is empty, so the space where the parens are would just appear blank when there aren't any assignments under this category.

This similarly affects Ungraded assignments' potential score.

The relevant code seems to be here and here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant