Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

junit: Simplify and improve inputs directory discovery #585

Merged
merged 2 commits into from Jan 18, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Jan 4, 2023

Inputs directory handling was confusing as e.g. Maven doesn't copy over empty resource directories by default. Instead of relying on that, always fall back to locating the inputs directory in the source tree and even try to create it if at least the test resources root is found.

@fmeum fmeum force-pushed the 489-improve-resource-path-handling branch from 983b7d7 to ddc503a Compare January 17, 2023 15:45
@fmeum fmeum marked this pull request as ready for review January 17, 2023 15:58
Inputs directory handling was confusing as e.g. Maven doesn't copy over
empty resource directories by default. Instead of relying on that,
always fall back to locating the inputs directory in the source tree and
even try to create it if at least the test resources root is found.
@fmeum fmeum force-pushed the 489-improve-resource-path-handling branch from ddc503a to 55cd5b0 Compare January 18, 2023 08:26
@fmeum fmeum enabled auto-merge (rebase) January 18, 2023 08:26
@fmeum fmeum merged commit 02996d9 into main Jan 18, 2023
@fmeum fmeum deleted the 489-improve-resource-path-handling branch January 18, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants