🚨 : make attributes private

gaia-app · Jan 9, 2020 · 86eecd3 · 86eecd3
1 parent c8b7e6e
commit 86eecd3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/main/java/io/codeka/gaia/registries/controller/GithubRegistryController.kt b/src/main/java/io/codeka/gaia/registries/controller/GithubRegistryController.kt
@@ -18,14 +18,14 @@ import java.util.*
 @RequestMapping("/api/registries/github")
 @Secured
 class GithubRegistryController(
-        val githubRegistryApi: RegistryApi<GithubRepository>,
-        val hclParser: HclParser,
-        val cliRepository: TerraformCLIRepository,
-        val moduleRepository: TerraformModuleRepository) {
+        private val githubRegistryApi: RegistryApi<GithubRepository>,
+        private val hclParser: HclParser,
+        private val cliRepository: TerraformCLIRepository,
+        private val moduleRepository: TerraformModuleRepository) {
 
     @GetMapping("/repositories")
     fun getRepositories(user: User): List<String> {
-        return this.githubRegistryApi.getRepositories(user);
+        return this.githubRegistryApi.getRepositories(user)
     }
 
     @GetMapping("/repositories/{owner}/{repo}/import")

diff --git a/src/test/java/io/codeka/gaia/registries/controller/GithubRegistryControllerTest.kt b/src/test/java/io/codeka/gaia/registries/controller/GithubRegistryControllerTest.kt
@@ -90,8 +90,6 @@ class GithubRegistryControllerTest{
     }
 }
 
-fun <T> Stubber.whenever(mock: T) = `when`(mock)
-
 inline fun <T> whenever(methodCall: T): OngoingStubbing<T> {
     return Mockito.`when`(methodCall)!!
 }