Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP requirement is wrong #16

Open
clphillips opened this issue Apr 22, 2015 · 1 comment
Open

PHP requirement is wrong #16

clphillips opened this issue Apr 22, 2015 · 1 comment

Comments

@clphillips
Copy link
Contributor

Base requirement is really 5.3, not 5.4. Only dev dependencies actually require 5.4.

    "require": {
        "php": ">=5.4.0",
        "fzaninotto/faker": "~1.4"
    },
    "require-dev": {
        "mockery/mockery": "~0.9",
        "illuminate/support": "~5",
        "illuminate/database": "~5",
        "phpunit/phpunit": "~4.6"
    },

Should be:

    "require": {
        "php": ">=5.3.0",
        "fzaninotto/faker": "~1.4"
    },
    "require-dev": {
        "php": ">=5.4.0",
        "mockery/mockery": "~0.9",
        "illuminate/support": "~5",
        "illuminate/database": "~5",
        "phpunit/phpunit": "~4.6"
    },
@tabennett
Copy link
Contributor

Yeah. It was 5.3 before, but the Illuminate/Support/Str library is now using Traits (since 4.2 I believe). That's another reason why that library should really be removed and replaced with something simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants