Skip to content
This repository has been archived by the owner on Mar 8, 2024. It is now read-only.

Determine whether the client IDs used for android are secrets #40

Open
avenmia opened this issue May 3, 2022 · 4 comments
Open

Determine whether the client IDs used for android are secrets #40

avenmia opened this issue May 3, 2022 · 4 comments
Assignees

Comments

@avenmia
Copy link

avenmia commented May 3, 2022

In order to get the app to run on android, I needed to add the following:

  • google-services.json (in android\app)
  • facebook_app_id (in android\app\src\main\res\values)
  • facebook_client_token (in android\app\src\main\res\values)

This task is to determine whether or not these are secrets and shouldn't be committed or whether they are public and safe to commit, or some combination

Some Resources:

https://developers.facebook.com/docs/facebook-login/guides/access-tokens
https://developers.google.com/android/guides/google-services-plugin

@avenmia avenmia changed the title Determine whether or not we can commit the client IDs needed for android or if they need to be injected Determine whether the client IDs used for android are secrets May 3, 2022
@avenmia
Copy link
Author

avenmia commented May 5, 2022

Looks like google-services.json is safe to commit.
https://groups.google.com/g/firebase-talk/c/bamCgTDajkw/m/uVEJXjtiBwAJ?pli=1

@avenmia
Copy link
Author

avenmia commented May 5, 2022

Looks like the Facebook app_id is safe to commit.
https://stackoverflow.com/a/35404517/7331107

@avenmia
Copy link
Author

avenmia commented May 5, 2022

The client_id is also safe to commit.
https://developers.facebook.com/docs/facebook-login/guides/access-tokens

@tyliec
Copy link
Sponsor Member

tyliec commented May 10, 2022

nice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants