Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a way to customize vscode version and categories #32

Merged
merged 2 commits into from Oct 9, 2021

Conversation

Makiyu-py
Copy link
Collaborator

I'm back
The title says it all lmao (sorry for the almost-late-night pr)

Usage:

ext = vscode.Extension(
    some_stuff="here",
    categories=["testing"],  # default here is ["Other"]
    vscode_version="^1.56.0",  # default is "^1.58.0" (https://code.visualstudio.com/api/working-with-extensions/publishing-extension#visual-studio-code-compatibility)
    other_stuff=["h", "e", "r", "e"]
)

I guess this also fixes #26 since you can now customize the min-max vsc version for your extension
(also, happy hacktoberfest! :D)

@CodeWithSwastik
Copy link
Owner

I was looking into moving the extra params into a config Class but this will do for now 👍

@CodeWithSwastik CodeWithSwastik merged commit b700f86 into CodeWithSwastik:main Oct 9, 2021
@Makiyu-py Makiyu-py deleted the pkg-update branch October 16, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension is not compatible with Code 1.56. Extension requires ^1.59. Wrong code.exe used.
2 participants