Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how profile pictures are stored #115

Open
1 task
lyallstewart opened this issue May 28, 2022 · 0 comments · May be fixed by #125
Open
1 task

Fix how profile pictures are stored #115

lyallstewart opened this issue May 28, 2022 · 0 comments · May be fixed by #125
Labels
enhancement New feature or request

Comments

@lyallstewart
Copy link
Member

Purpose

Fix how we're storing staff data, especially around profile pictures.

Is your feature request related to a problem? Please describe.

At the moment, our current way of having a staff.JSON file linking to Discord's own profile picture hosting is flawed for two main reasons:

  • It cannot work with blank profile pictures as Discord handles these separately, hence why tgrtim has had to be accounted for individually.
  • When a staff member changes their profile picture, the image breaks, rather than just being outdated.

Proposed Solution

Instead of having a JSON file, use a normal .JS file with an exported object, this would (since React weirdness around having to import local images) allow us to download all the profile pictures and link to them directly, rather than using Discord's own links.

Acceptance Criteria

Please list the requirements the implementation of this feature should meet.

  • Profile pictures should be downloaded and linked to directly rather than using Discord's own hosting.
@lyallstewart lyallstewart added the enhancement New feature or request label May 28, 2022
@lyallstewart lyallstewart changed the title Overhaul staff data storage Fix how profile pictures are stored May 28, 2022
@lyallstewart lyallstewart linked a pull request Aug 1, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant