Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Bulma Font Sizes on Resource Page Instead of Hardcoded px #117

Open
1 task
yingmo55 opened this issue May 28, 2022 · 0 comments
Open
1 task

Using Bulma Font Sizes on Resource Page Instead of Hardcoded px #117

yingmo55 opened this issue May 28, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yingmo55
Copy link
Contributor

Purpose

Better & more responsive font sizes.

Is your feature request related to a problem? Please describe.

Currently, the font sizes on the resource page are hard coded with a px value. (location: ./src/assets/sass/views/_resources.scss) It is good practice to not use hard-coded font-size to make the website more responsive.

Proposed Solution

You can change the font-size by adding classes such as is-size-2 is-size-3-mobile to the className attribute of text elements.
See Typography helpers for more details.

Describe alternatives you've considered (optional)

We also talked about setting a unified font-size for text elements such as <h1> <h2> <p>

Acceptance Criteria

Please list the requirements the implementation of this feature should meet.

  • change the front-sizes on Resource Page to Bulma Font Sizes and remove hard-coded px values

Additional context

N/A

@yingmo55 yingmo55 added enhancement New feature or request good first issue Good for newcomers labels May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant