New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency GoAOP to have PHP5.6/PHP7 features support #92
Comments
Version 1.0.x of Master branch (aka 2.x-dev) works with PHP>=5.6 and has a support for PHP7 features because reflection engine was changed to the goaop/parser-reflection component. However, there are no stable 2.x tags right now, if you need something stable for 2.x, then ping me to release a tag. |
I think we are ok to update dependency to GoAOP v 1.0 (not sure why I missed its release, and didn't update earlier) but looks it won't solve your problems for now. Once GoAOP v2 is out we can switch to it. In this case I propose to stick our versions to GoAOP and follow them. So AspectMock 1.0 to work with GoAOP 1.0 and AspectMock 2.0 to work with GoAOP 2.0... |
@lisachenko it seems that GoAOP v2 is really in demand. So could you release it? |
@DavertMik I can release it, but there are things to do and not tested very well. Main change is changing reflection engine to Alternatively, you can fork your master to 1.x and change all the things for master branch ) |
As GoAOP v2 isn't ready then maybe you could make a branch, set |
Sure! But please release something called |
bump! GoAOP already released |
Waiting for update dependencies. |
It's not just like updating a version of Go AOP and getting it run. It requires some major rewrite of our transformer, so please wait for that. |
bump! GoAOP released |
@DavertMik any idea how soon GoAOP 2.0 will be integrated? we want php 7 : ) |
Done in master. 2.0 to be released in next hour |
Currently there are errors when doubling code that contains new language features that cannot be parsed by old GoAOP. GoAOP with version 1.0.x supports new language features (but breaks backwards compatybility as it requires php>=5.6).
The text was updated successfully, but these errors were encountered: