fix(Puppeteer): #waitForText - Cannot read property 'innerText' of null #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vorobeyko
requested review from
DavertMik,
reubenmiller,
elukoyanov,
pablopaul and
kobenguyent
kobenguyent
reviewed
Feb 4, 2020
kobenguyent
previously approved these changes
Feb 7, 2020
kobenguyent
approved these changes
Feb 9, 2020
DavertMik
added a commit
that referenced
this pull request
Feb 11, 2020
DavertMik
approved these changes
Feb 11, 2020
DavertMik
added a commit
that referenced
this pull request
Feb 11, 2020
* udpated changelog * initial Playwright implementation * (fix): add wait for actions call * (fix): more failed webapi tests * (test): trigger playwright tests on CI * (lint): please hound ^^ * (fix): remove wrongly use .only * (fix): setCookie method to parse param as array * (fix): change to setCookies * (fix): tabs tests * (fix): please hound * (fix): remove unused console.log * updated Playwright to make all tests pass * updated playwright tests to start a server * upated server start * Create playwright.md * (fix): update based on comments * add playwright option to init cmd * add option to show browser when initialising * (fix): basic auth we have #2178 to fix puppeteer helper, so this patch will be applied in Playwright as well. * enable describe('Playwright - BasicAuth') test * updated to playwright 0.10.0 * fixed tests, updated docs * updated docs * ported patch from #2181 Co-authored-by: Peter Nguyen Tr <peter.nguyentr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Webdriver
Puppeteer
Nightmare
REST
Appium
Protractor
TestCafe
Description of this PR, which problem it solves
Resolves #issueId (if applicable).
Type of change
Checklist:
npm run docs)npm run lint)npm test)