New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix work with promise chains #568
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
af69c3e
Run after block after test fails
62e2005
fix interface test
2d30ea2
fix formatting
0c771f5
refactor work with chains
ee83622
fix typo
7b7c0ba
remove second after
7c69ce5
correct chain order
e9329fe
fix formatting
b48f9ac
Add compliting _after _afterSuite if after hooks failed
cf8e60a
fix formatting
9a67d45
Add new hook finishTest
cce7f76
fix formatting
5eb9b3e
return recorder back
98b8358
fix formatting
55a0482
add closing tabs for Protractor and selenium
110d3c1
fix formatting
79f5c99
fix uppercase
b63a20f
fix hooks
68bbe79
clear localstorage and close tabs with keepCookies flag
206c1b7
fix formatting
ce22a6a
Fixes
db517cc
remove defenition
bdd1c64
add step execution time in Verbose mode
00c35dd
fix formatting
c90788c
Add step execution time to output
30d15f5
fix formatting
4871219
fixes after review
58f51ce
fix formatting
62adade
fix typo
e3b245e
fix tests with generator
861b47a
fix formatting
91a5df9
add mochaFile override
e9ec704
add report file name in override config for junit reporter
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is a bit confusing. Ok, these are special events fired by a failing
after
andafterSuite
.Ok, let's try to clarify their context. Those methods should not fail, so if they do it is an
error
.So I propose to have next events:
test.after.error
, andsuite.after.error
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't use test.after/suite.after, because they are already defined. I suggest test.afterError, suite.afterError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good