Don't run test if exception was thrown in _before of a module #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works in all formats except Unit Closes Codeception#4191
DavertMik
reviewed
May 8, 2017
| } catch (\Exception $er) { | ||
| // failure is created: not a user's test code error so we don't need detailed stacktrace | ||
| $this->testResult->addError($this, new \PHPUnit_Framework_AssertionFailedError($er->getMessage()), 0); | ||
| $this->ignored = true; |
There was a problem hiding this comment.
not sure why the test was executed even when it was marked as ignored 😕
|
Thanks. Very nice fix |
|
I run 26 tests. And if the second does not pass, then all other tests are not performed. It's horrible. |
|
I know, it is fixed already and will be released soon. |
chris1312
pushed a commit
to chris1312/Codeception
that referenced
this pull request
Jun 16, 2017
…ption#4197) * Created tests for execution when exception is thrown in _before of module * Don't run test if exception was thrown in _before of module Works in all formats except Unit Closes Codeception#4191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed that for all test formats except Unit - it has to be fixed in PHPUnit.
One more reason to use Codeception formats.
Closes #4191