JsonType: Allow to use : in regex filter

[ellisgl]

Fixes #2501
Fixes regex filter handling in Util\JsonType

[DavertMik]

Looks good to me but I don't understand what's happening there 😛
Could you add some inline comments to your code?
I know regex is complicated by itself but some minor comments would help

[ellisgl]

Looks good to me but I don't understand what's happening there 😛
Could you add some inline comments to your code?
I know regex is complicated by itself but some minor comments would help

I'll get comments in tonight.

[ellisgl]

Looks like wercker/build stuff needs to fixed.

[Naktibalda]

I tried to match time with 'time' => 'string:regex(~\d\d:\d\d:\d\d~)', in my project,
so I copy-pasted your patch to see if it works.
Matching works correctly, but one thing it messes up is error message.

Here is the output I got:

 Fail  `time: '2018-12-21'` is of type `string:regex($$0)`

I would like to see the actual pattern instead of $$0.

This issue was visible in my failed attempt to create failing test: https://travis-ci.org/Codeception/Codeception/jobs/467890679

Failed asserting that '`text: '21@:00'` is of type `string:regex($$0):\dd$~)`' is true.

[ellisgl]

Doesn't everyone know what $$0 is? 😂

I'll look when I get home. It'll probably be a case of just having to create a second array of the original, before the replacements.

Other than that, another way to kill off these issues would invlove rewriting the "API" to look like 'Array Key' => ['type' => string, 'filter' => ['regex'=> '/.*/']]

[Naktibalda]

It should be enough to use a different variable instead of $type to store result of preg_replace_callback to avoid overriding original value of $type.

[ellisgl]

OK - so there actually was an issue with the regex I was using which prematurely stopped on that example you gave (Which I had a pattern I wrote during the last commit that I thought was overkill, but I guess it wasn't). I also had to just replace the $$\d+ in the type. Reason for this was because of the split on | and the split on : would have still caused some issues if I had just used a second variable for the regexes. I also did some fixes around PHP Inspections (EA Extended) suggestions.

[Naktibalda]

It looks good to me now.