Improve file path detection for groups #5609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### What are you trying to achieve?
Hi there,
I was trying to add some groups to my suites but I encountered a weird case: some groups were unable to load tests, and some were able to do.
After some investigation, I found out that this case occurs :
- when you set your suite path to `.`
- when you define groups directly in your suite config file
馃檲 no problem happens if you use annotation directly in your test files.
#### What do you get instead?
The binary does not run the tests.
```bash
application@356115a48d2a:/app$ php vendor/bin/codecept run -g api-package
Codeception PHP Testing Framework v3.0.0
Powered by PHPUnit 7.5.9 by Sebastian Bergmann and contributors.
Running with seed:
[Groups] api-package
Api Tests (0) -------------------------------------------------------------------------------------------------------------------------
---------------------------------------------------------------------------------------------------------------------------------------
Time: 251 ms, Memory: 26.00 MB
No tests executed!
```
### Details
* Codeception version: 3.0.0
* PHP Version: 7.2.15
* Operating System: Debian
* Installation type: Composer
* Suite configuration:
```yml
suites:
api:
actor: ApiTester
path: .
modules:
enabled:
- Symfony:
app_path: 'app'
environment: 'test'
kernel_class: MicroKernel
- REST:
depends: Symfony
- Doctrine2:
depends: Symfony
- \Helper\ILoveMyHelper
error_level: "E_ALL & ~E_STRICT & !E_DEPRECATED"
paths:
tests: tests
output: tests/_output
data: tests/_data
support: tests/_support
settings:
shuffle: false
lint: true
groups:
api: [tests/]
api-package: [tests/./package] # this works fine
api-package-2: [tests/package] # this does not work without the fix
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to achieve?
Hi there,
I was trying to add some groups to my suites but I encountered a weird case: some groups were unable to load tests, and some were able to do.
After some investigation, I found out that this case occurs :
.馃檲 no problem happens if you use annotation directly in your test files.
What do you get instead?
The binary does not run the tests.
application@356115a48d2a:/app$ php vendor/bin/codecept run -g api-package Codeception PHP Testing Framework v3.0.0 Powered by PHPUnit 7.5.9 by Sebastian Bergmann and contributors. Running with seed: [Groups] api-package Api Tests (0) ------------------------------------------------------------------------------------------------------------------------- --------------------------------------------------------------------------------------------------------------------------------------- Time: 251 ms, Memory: 26.00 MB No tests executed!Details